Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added svg icon #11

Merged
merged 3 commits into from
Dec 15, 2021
Merged

Added svg icon #11

merged 3 commits into from
Dec 15, 2021

Conversation

artimanputra
Copy link
Contributor

This PR is regarding issue #3. Added SVG for font awesome icons.

Copy link
Owner

@ExpressHermes ExpressHermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs additional work.

@artimanputra Check these out to understand how you can replace the icons:

Ping on slack channel if you don't understand the process

@ExpressHermes
Copy link
Owner

Hey @artimanputra the changes look good. Can you post a few screenshots of the updated pages so I can verify the icons?

@artimanputra
Copy link
Contributor Author

Hey @artimanputra the changes look good. Can you post a few screenshots of the updated pages so I can verify the icons?

Sure.

@artimanputra
Copy link
Contributor Author

Hey @artimanputra the changes look good. Can you post a few screenshots of the updated pages so I can verify the icons?

@ExpressHermes Here is the screenshot.
Screenshot_3

@ExpressHermes ExpressHermes merged commit 79b4b49 into ExpressHermes:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants