Only use serial crsf battery sensor if detected #1968
Conversation
| @@ -74,5 +76,6 @@ class Telemetry | |||
| bool callEnterBind; | |||
| bool callUpdateModelMatch; | |||
| bool sendDeviceFrame; | |||
| bool crsfBatterySensorDetected; | |||
There was a problem hiding this comment.
I could be wrong, but its probably not the best practice to assume this bool will initialise to false...
There was a problem hiding this comment.
C++ guarantees that variables are created with a specific initial value. And for booleans that is the false value 😄
There was a problem hiding this comment.
Thats not what 5mins on stackoverflow taught me, but fair enough. I was always told that member vars should always be initialised (i.e. in the class constructor etc.)
There was a problem hiding this comment.
There was a problem hiding this comment.
Im happy to change it just for the readability. But there are multiple instances that should be updated and probably not as part of this PR.
There was a problem hiding this comment.
Yep, you are right Wez, only globals are automatically set to defaults.
If a receiver contains an internal battery sensor, and a user also connects a FC with vbat tlm, then they will both be sent to the handset. This may cause confusion with the numbers being displayed, or alarms configured.
This PR disables devAnalogVbat (the internal battery sensor) if a serial crsf battery sensor is detected.