Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct system paths in language file #126

Merged
merged 2 commits into from
Feb 13, 2019
Merged

correct system paths in language file #126

merged 2 commits into from
Feb 13, 2019

Conversation

meatpaste
Copy link

Overview

The language file showed a hard coded file path during a permission error, i've changed it to use dynamic system path variable.

Resolves #NN.

Nature of This Change

  • 🐛 Fixes a bug
  • 🚀 Implements a new feature
  • 🛁 Refactors existing code
  • 💅 Fixes coding style
  • ✅ Adds tests
  • 👽 Adds new dependency
  • 🔥 Removes unused files / code
  • 🔒 Improves security

Is this backwards compatible?

  • Yes
  • No

Documentation

User Guide Pull Request: https://github.com/ExpressionEngine/ExpressionEngine-User-Guide/pulls/NNN

@kevincupp
Copy link
Contributor

This looks good, thanks! Can you just add something to the patch.rst changelog? Maybe something like:

- Changed hard-coded system paths to be dynamic in some error messages. (`#126 <https://github.com/ExpressionEngine/ExpressionEngine/pull/126>`__)

@meatpaste
Copy link
Author

@kevincupp sure, i've added that in

@kevincupp kevincupp merged commit 2fab1db into ExpressionEngine:stability Feb 13, 2019
@kevincupp
Copy link
Contributor

Thank you!

@meatpaste meatpaste deleted the patch-1 branch February 13, 2019 19:43
intoeetive pushed a commit that referenced this pull request Oct 27, 2021
only fixed copyright dates and name EECORE-107 EECORE-109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants