Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct system paths in language file #126

Merged
merged 2 commits into from Feb 13, 2019

Conversation

Projects
None yet
2 participants
@meatpaste
Copy link
Contributor

meatpaste commented Feb 13, 2019

Overview

The language file showed a hard coded file path during a permission error, i've changed it to use dynamic system path variable.

Resolves #NN.

Nature of This Change

  • πŸ› Fixes a bug
  • πŸš€ Implements a new feature
  • πŸ› Refactors existing code
  • πŸ’… Fixes coding style
  • βœ… Adds tests
  • πŸ‘½ Adds new dependency
  • πŸ”₯ Removes unused files / code
  • πŸ”’ Improves security

Is this backwards compatible?

  • Yes
  • No

Documentation

User Guide Pull Request: https://github.com/ExpressionEngine/ExpressionEngine-User-Guide/pulls/NNN

@kevincupp

This comment has been minimized.

Copy link
Contributor

kevincupp commented Feb 13, 2019

This looks good, thanks! Can you just add something to the patch.rst changelog? Maybe something like:

- Changed hard-coded system paths to be dynamic in some error messages. (`#126 <https://github.com/ExpressionEngine/ExpressionEngine/pull/126>`__)
@meatpaste

This comment has been minimized.

Copy link
Contributor Author

meatpaste commented Feb 13, 2019

@kevincupp sure, i've added that in

@kevincupp kevincupp merged commit 2fab1db into ExpressionEngine:stability Feb 13, 2019

0 of 2 checks passed

ci/circleci: test_php_56 CircleCI is running your tests
Details
ci/circleci: test_php_71 CircleCI is running your tests
Details
@kevincupp

This comment has been minimized.

Copy link
Contributor

kevincupp commented Feb 13, 2019

Thank you!

@meatpaste meatpaste deleted the meatpaste:patch-1 branch Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.