Resolved #3439 where using File field limited to upload directory on other site would result in JavaScript error

[intoeetive]

Resolved #3439 where using File field limited to upload directory on other site would result in JavaScript error

@robinsowell please review. We need to test it in different combinations (sites, member role permissions, existing files etc.) to make sure it does not cause data loss

[robinsowell]

I'm running into issues, particularly in a matrix field.

I download the branch, did default install. Made a file field called 'blog_file' which is a file field limited to the 'blog' directory. This is all on the default site. Also note, I'm showing version 7.2.17.

I made a second msm site, 'dos'. Made a channel in dos, assigned the 'blog' group and my new 'blog_file' field.

Go to add entry in my dos channel. No js errors- which is good and an improvement. My blog field shows:

That's correct. My grid field could be a bit better on messaging, but I still don't trigger js errors nor can I do a bad upload:

HOWEVER- if I now go make a file upload directory in the dos site, now when I go to add an entry in dos channel, I still don't have js error but my file field looks like:

.

If I do drag/drop to it I get:

Weirdly, my matrix field with the file field actually gives me the option of the file field on the dos site:

Which it should not. If I go to the field settings while on dos, it doesn't show any directory selected, which is what happens when the directory chosen isn't available on the site you are currently on:

I had similar issues if I just dropped the updated files into my 7.3 install to test.

[robinsowell]

See comments, it's doing odd things still.

Please review again. I'm not getting the kind of Matrix UI you are showing, but it's working without errors for me. The file and Grid fields are working fine - but I'm also wondering if there are edge cases I did not think of

[robinsowell]

@intoeetive I can't get it to break again. I like seeing the debug in the console:

That's useful. I will grant, my head is spinning from all of the possible permutations testing this, but I'm calling it good.

I do still get a radio with nothing selecting in the actual field settings when an unavailable directory is chosen, but I'm going to put that in as a seperate (minor) bug- I think a flag or... something belongs there. Possibly a validation error.