Resolved #3439 where using File field limited to upload directory on other site would result in JavaScript error

system/ee/language/english/fieldtypes_lang.php

@@ -191,6 +191,10 @@
 
     'file_dnd_create_directory' => 'Create New Directory',
 
+    'file_dnd_no_directories' => 'No upload directories available',
+
+    'file_dnd_no_directories_desc' => 'This field is limited to upload directory not available for current member and site.',
+
     'file_grid_vertical_layout_title' => 'File Grid layout',
 
     /* Grid */

system/ee/legacy/libraries/File_field.php

@@ -27,11 +27,11 @@
      *
      * @param string $field_name The name of the field
      * @param string $data The data stored in the file field
      * 		e.g. {filedir_x}filename.ext
      * @param string $allowed_file_dirs The allowed file directory
      * 		Either 'all' or ONE directory ID
      * @param string $content_type The content type allowed.
      * 		Either 'all' or 'image'
      * @return string Fully rendered file field
      */
     public function field($field_name, $data = '', $allowed_file_dirs = 'all', $content_type = 'all', $filebrowser = true, $existing_limit = null)
@@ -162,11 +162,11 @@
      *
      * @param string $field_name The name of the field
      * @param string $data The data stored in the file field
      * 		e.g. {filedir_x}filename.ext
      * @param string $allowed_file_dirs The allowed file directory
      * 		Either 'all' or ONE directory ID
      * @param string $content_type The content type allowed.
      * 		Either 'all' or 'image'
      * @return string Fully rendered file field
      */
     public function dragAndDropField($field_name, $data = '', $allowed_file_dirs = 'all', $content_type = 'all')
@@ -284,13 +284,13 @@
         // If file field is just a file ID
         if (! empty($data) && is_numeric($data)) {
             $file = ee('Model')->get('File', $data)->with('UploadDestination')->first(true);
         }
         // If the file field is in the "{file:XX:url}" format
         elseif (is_string($data) && preg_match('/^{file\:(\d+)\:url}/', $data, $matches)) {
             // Set upload directory ID and file name
             $file_id = $matches[1];
             $file = ee('Model')->get('File', $file_id)->with('UploadDestination')->first(true);
         }
         // If the file field is in the "{filedir_n}image.jpg" format
         elseif (is_string($data) && preg_match('/^{filedir_(\d+)}/', $data, $matches)) {
             // Set upload directory ID and file name
@@ -311,8 +311,8 @@
     /**
      * Initialize the file browser given a configuration array and an endpoint url
      * @param array $config Associative array containing five different keys and values:
      * 		- publish: set to TRUE if you're on the publish page, optionally
      * 			just pass an empty array or none at all for the same behavior
      * 		- trigger: the selector to pass to jQuery to create a trigger for
      * 			the file browser
      * 		- field_name: the field you're operating on. If undefined, it will
@@ -1007,6 +1007,8 @@
                 'lang.file_dnd_uploading_to' => lang('file_dnd_uploading_to'),
                 'lang.file_dnd_upload_new' => lang('file_dnd_upload_new'),
                 'lang.file_dnd_create_directory' => lang('file_dnd_create_directory'),
+                'lang.file_dnd_no_directories' => lang('file_dnd_no_directories'),
+                'lang.file_dnd_no_directories_desc' => lang('file_dnd_no_directories_desc'),
 
                 'dragAndDrop.uploadDesinations' => ee('View/Helpers')->normalizedChoices($upload_destinations),
                 'dragAndDrop.endpoint' => ee('CP/URL')->make('addons/settings/filepicker/ajax-upload')->compile(),

themes/ee/asset/javascript/src/fields/file/drag_and_drop_upload.es6

@@ -68,6 +68,10 @@ class DragAndDropUpload extends React.Component {
 
     var directory = this.checkChildDirectory(EE.dragAndDrop.uploadDesinations, directory);
 
+    if (typeof(directory) === 'undefined') {
+      return ' ';
+    }
+
     return directory.label
   }
 
@@ -80,6 +84,13 @@ class DragAndDropUpload extends React.Component {
       }
     } else {
       var directory = this.checkChildDirectory(EE.dragAndDrop.uploadDesinations, directory);
+      if (typeof(directory) === 'undefined') {
+        return {
+          upload_location_id: null,
+          path: '',
+          directory_id: 0
+        };
+      }
       if (directory.value == directory.upload_location_id) {
         directory.directory_id = 0
       } else {
@@ -544,6 +555,12 @@ class DragAndDropUpload extends React.Component {
       subheading = EE.lang.file_dnd_choose_directory_before_uploading
     }
 
+    if (EE.dragAndDrop.uploadDesinations.length == 0 && this.state.directory != 'all') {
+      heading = EE.lang.file_dnd_no_directories
+      subheading = EE.lang.file_dnd_no_directories_desc
+      this.props.showActionButtons = false;
+    }
+
     let checkChildren = this.directoryHasChild(this.props.allowedDirectory);
     let uploadDirectoriesForDropdown = EE.dragAndDrop.uploadDesinations;
     if (typeof(this.props.roleAllowedDirectoryIds) !== 'undefined' && this.props.roleAllowedDirectoryIds.length > 0) {

themes/ee/asset/javascript/src/fields/file/drag_and_drop_upload.js

@@ -295,6 +295,11 @@ var DragAndDropUpload = /*#__PURE__*/function (_React$Component) {
     value: function getDirectoryName(directory) {
       if (directory == 'all') return null;
       var directory = this.checkChildDirectory(EE.dragAndDrop.uploadDesinations, directory);
+
+      if (typeof directory === 'undefined') {
+        return ' ';
+      }
+
       return directory.label;
     }
   }, {
@@ -309,6 +314,14 @@ var DragAndDropUpload = /*#__PURE__*/function (_React$Component) {
       } else {
         var directory = this.checkChildDirectory(EE.dragAndDrop.uploadDesinations, directory);
 
+        if (typeof directory === 'undefined') {
+          return {
+            upload_location_id: null,
+            path: '',
+            directory_id: 0
+          };
+        }
+
         if (directory.value == directory.upload_location_id) {
           directory.directory_id = 0;
         } else {
@@ -628,6 +641,12 @@ var DragAndDropUpload = /*#__PURE__*/function (_React$Component) {
         subheading = EE.lang.file_dnd_choose_directory_before_uploading;
       }
 
+      if (EE.dragAndDrop.uploadDesinations.length == 0 && this.state.directory != 'all') {
+        heading = EE.lang.file_dnd_no_directories;
+        subheading = EE.lang.file_dnd_no_directories_desc;
+        this.props.showActionButtons = false;
+      }
+
       var checkChildren = this.directoryHasChild(this.props.allowedDirectory);
       var uploadDirectoriesForDropdown = EE.dragAndDrop.uploadDesinations;