Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(HamsterBallLocomotion): Update Camera Rig position by grabbing the interior of a sphere collider - resolves #1630 #1638

Closed
wants to merge 5 commits into from
Closed

feat(HamsterBallLocomotion): Update Camera Rig position by grabbing the interior of a sphere collider - resolves #1630 #1638

wants to merge 5 commits into from

Conversation

williamrjackson
Copy link

Updates the position of the Camera Rig by rolling a grabbing the sides of a sphere collider's interior, like a hamster ball.

[https://waffle.io/thestonefox/VRTK/cards/5a141a033eb80a02602a376b]

@GitCop
Copy link

GitCop commented Nov 28, 2017

There were the following issues with your Pull Request

  • Commit: 1daf52f
  • Your commit message body contains a line that is longer than 72 characters
  • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/thestonefox/SteamVR_Unity_Toolkit

This message was auto-generated by https://gitcop.com

@williamrjackson williamrjackson mentioned this pull request Nov 28, 2017
Open
@williamrjackson williamrjackson changed the title Hamster Ball Locomotion feat(HamsterBallLocomotion): General implementation Nov 28, 2017
@GitCop
Copy link

GitCop commented Nov 28, 2017

There were the following issues with your Pull Request

  • Commit: 1daf52f
  • Your commit message body contains a line that is longer than 72 characters
  • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/thestonefox/SteamVR_Unity_Toolkit

This message was auto-generated by https://gitcop.com

1 similar comment
@GitCop
Copy link

GitCop commented Nov 30, 2017

There were the following issues with your Pull Request

  • Commit: 1daf52f
  • Your commit message body contains a line that is longer than 72 characters
  • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/thestonefox/SteamVR_Unity_Toolkit

This message was auto-generated by https://gitcop.com

@williamrjackson williamrjackson changed the title feat(HamsterBallLocomotion): General implementation feat(HamsterBallLocomotion): Update Camera Rig position by grabbing the interior of a sphere collider Nov 30, 2017
@GitCop
Copy link

GitCop commented Nov 30, 2017

There were the following issues with your Pull Request

  • Commit: 1daf52f
  • Your commit message body contains a line that is longer than 72 characters
  • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/thestonefox/SteamVR_Unity_Toolkit

This message was auto-generated by https://gitcop.com

@GitCop
Copy link

GitCop commented Nov 30, 2017

There were the following issues with your Pull Request

  • Commit: 1daf52f

  • Your commit message body contains a line that is longer than 72 characters

  • Commits must be in the following format: %{type}(%{scope}): %{description}

  • Commit: 388ea0b

  • Your subject line is longer than 72 characters

Guidelines are available at https://github.com/thestonefox/SteamVR_Unity_Toolkit

This message was auto-generated by https://gitcop.com

@thestonefox
Copy link
Member

This pull request needs a tidy up.

Requires a squash and a better commit message so we can clean up the gitcop messages.

Let me know if you need any guidance.

@GitCop
Copy link

GitCop commented Dec 16, 2017

There were the following issues with your Pull Request

  • Commit: 6863447
  • Your commit message body contains a line that is longer than 72 characters
  • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/thestonefox/SteamVR_Unity_Toolkit

This message was auto-generated by https://gitcop.com

@GitCop
Copy link

GitCop commented Dec 16, 2017

There were the following issues with your Pull Request

  • Commit: 1daf52f

  • Your commit message body contains a line that is longer than 72 characters

  • Commits must be in the following format: %{type}(%{scope}): %{description}

  • Commit: a2abe7c

  • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/thestonefox/SteamVR_Unity_Toolkit

This message was auto-generated by https://gitcop.com

@williamrjackson
Copy link
Author

Looks like I'm needing some guidance. I'll take you up on your offer :) Thanks!

thestonefox and others added 5 commits December 16, 2017 14:49
@thestonefox @williamrjackson
feat(SDK): add WindowsMR support for SteamVR
ddc1a56 
The SteamVR SDK also supports Windows Mixed Reality devices but again
has some slight differences such as controller collider shapes and
controller orientations.

The Windows Mixed Reality controller also has an additional thumbstick
as well as a touchpad. The thumbstick is now referred to as
`TouchpadTwo` but only has axis change events as the button press is
reserved as a system event in SteamVR and there is no touch sensing
available.
@thestonefox @williamrjackson
feat(SDK): add touchpad two touch state
326e705 
The thumbstick (touchpad two) on the WindowsMR controller doesn't
have a touch sensor but it is prudent to know when it is being
touched so a touchpad two touch button event can be created.

This is useful for enabling the pointers when the thumbstick is being
used as the default input for teleporting on WindowsMR is usually
pressing the thumbstick.

This has been implemented by just checking if the axis on the
thumbstick is over a set threshold. The threshold is embedded in
the SteamVR Controller class so isn't overly easy to change at this
moment.
@thestonefox @williamrjackson
feat(Pointers): allow different axis to control direction indicator
44e5343 
The Pointer Direction Indicator can now be controlled by a different
coordinate axis such as touchpad two.
@thestonefox @williamrjackson
feat(Locomotion): allow alternative axis for touchpad control
f47acf8 
The Touchpad Control script can now use an alternative coordinate axis
for the control, such as touchpad two.
@williamrjackson
feat(HamsterBallLocomotion):Move grabbing sphere`
c4bf0c9
@GitCop
Copy link

GitCop commented Dec 16, 2017

There were the following issues with your Pull Request

  • Commit: c4bf0c9
  • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/thestonefox/SteamVR_Unity_Toolkit

This message was auto-generated by https://gitcop.com

@ExtendRealityLtd ExtendRealityLtd deleted a comment from takpare Jan 8, 2018
@thestonefox thestonefox changed the title feat(HamsterBallLocomotion): Update Camera Rig position by grabbing the interior of a sphere collider feat(HamsterBallLocomotion): Update Camera Rig position by grabbing the interior of a sphere collider - resolves #1630 Apr 6, 2018
@thestonefox
Copy link
Member

I'm going to start closing these, we can reopen them if anyone raises it

@thestonefox thestonefox closed this Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@williamrjackson @GitCop @thestonefox