Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Change text formatting #4

Open
wants to merge 1 commit into
base: final-fix
Choose a base branch
from
Open

[wip] Change text formatting #4

wants to merge 1 commit into from

Conversation

PlanetTheCloud
Copy link

Please try the code and see if it's working.
If it's not, please let me know and I'll try another solution,

@ardacebi ardacebi self-assigned this Aug 8, 2018
@ardacebi ardacebi self-requested a review August 8, 2018 10:50
@ardacebi ardacebi added the enhancement New feature or request label Aug 8, 2018
@ardacebi
Copy link
Member

ardacebi commented Aug 8, 2018

screenshot_2018-08-08 hello world - localhost

This is the output of your code.

@ardacebi ardacebi changed the title Changed the notification text (TESTING) [wip] Change text formatting Aug 8, 2018
@ardacebi ardacebi added this to the 1.1.0 milestone Aug 8, 2018
@ardacebi
Copy link
Member

ardacebi commented Aug 8, 2018

screenshot_2018-08-08 hello world - localhost 1

Latest output without the style.

@PlanetTheCloud
Copy link
Author

Please overwrite the core translation file with the code on this PR.

@ardacebi
Copy link
Member

@PlanetGamingGG What do you mean?

@ghost ghost changed the base branch from master to final-fix August 10, 2018 18:07
@ardacebi
Copy link
Member

Hey @PlanetTheCloud, It's been a long time. If you have time, can you remind me what was this PR for and what was our initial goal and what did we achieve with this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants