Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run d2-docker start --run-scripts for postprocessing scripts #7

Merged
merged 4 commits into from
Jul 20, 2020
Merged

Run d2-docker start --run-scripts for postprocessing scripts #7

merged 4 commits into from
Jul 20, 2020

Conversation

tokland
Copy link
Contributor

@tokland tokland commented Jul 8, 2020 •
edited
Loading

Closes #5

Requires EyeSeeTea/d2-docker#53

  • execute_scripts is not used on d2-docker images. Instead, use d2-docker start --run-scripts=/path/to/scripts --auth=AUTH_FROM_CFG_API_LOCAL.

@tokland tokland requested a review from ifoche July 8, 2020 08:31
@tokland tokland mentioned this pull request Jul 8, 2020
Merged
Base automatically changed from feature/d2-docker-support to development July 20, 2020 11:27
ifoche
ifoche approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@ifoche ifoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @tokland

@ifoche ifoche merged commit ece8371 into development Jul 20, 2020
@ifoche ifoche deleted the feature/run-scripts-on-d2-docker-45 branch July 20, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifoche ifoche ifoche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tokland @ifoche