Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default connection for autoconfigured server, Fix async texture readback #392

Merged
merged 2 commits into from Nov 27, 2014

Conversation

tribal-tec
Copy link
Member

No description provided.

@tribal-tec
Copy link
Member Author

FYI: @jafyvilla

@tribal-tec tribal-tec changed the title Add default connection for autoconfigured server Add default connection for autoconfigured server, Fix async texture readback Nov 19, 2014
@eile
Copy link
Member

eile commented Nov 25, 2014

single-node autoconfigs had no listening ports for security considerations. Can we make the add connection conditional on a ConfigParam?

@tribal-tec
Copy link
Member Author

Which security considerations? If one launches a eqPly default w/o any config, one cannot use the shipped 'feature' of adding windows on-the-fly. That seems more pressing to me, but I can be convinced otherwise.

@eile
Copy link
Member

eile commented Nov 25, 2014

Of having an open TCP port (with no input validation) in a desktop application. Maybe we can open the admin connection through a anon pipe somehow?

Edit: Having the app open it explicitly through ConfigParams seemed like a smaller evil, although I think it should be some process-local communication for the admin stuff.

Use PBO readback when available, texture otherwise to support Mesa OGL 1.4
@bbpbuildbot
Copy link

Build failed.
Refer to this link for build results (access rights to CI server needed):
https://bbpcode.epfl.ch/ci//job/oss.Equalizer.github/1/

@tribal-tec
Copy link
Member Author

Retest this please

@bbpbuildbot
Copy link

Build succeeded.
Refer to this link for build results (access rights to CI server needed):
https://bbpcode.epfl.ch/ci//job/oss.Equalizer.github/2/

eile added a commit that referenced this pull request Nov 27, 2014
Add default connection for autoconfigured server, Fix async texture readback
@eile eile merged commit 6e7cad8 into Eyescale:master Nov 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants