2.0 Event API #564
2.0 Event API #564
Conversation
| * @param event the received event. | ||
| * @return true when the event was handled, false if not. | ||
| * @version 1.0 | ||
| */ | ||
| EQ_API virtual bool processEvent( const Event& event ); | ||
| EQ_API virtual bool processEvent( EventType type, SizeEvent& event ); |
There was a problem hiding this comment.
event object cannot be const-ref?
There was a problem hiding this comment.
Updated doxygen to:
* The task of this method is to update the channel and event as necessary,
* and send it to the application using Config::sendEvent().
Aka there are use cases where the event is modified in place during processing, e.g., to set the originator ID to the channel id.
| @@ -429,13 +376,19 @@ class Config : public fabric::Config< Server, Config, Observer, Layout, Canvas, | |||
| LB_TIMEOUT_INDEFINITE ) const; | |||
|
|
|||
| /** | |||
| * Handle one config event. Thread safe. | |||
| * Handle the given event. Thread safe. | |||
| * | |||
| * @param command the event command. | |||
| * @return true if the event requires a redraw, false if not. | |||
| * @version 1.5.1 | |||
| */ | |||
| EQ_API virtual bool handleEvent( EventICommand command ); | |||
There was a problem hiding this comment.
Is the generic EventICommand handleEvent something an application would need/want to use? Or the new funcs are enough?
There was a problem hiding this comment.
Yes, for EVENT_USER or EVENT_OBSERVER_MOTION, which do not have a more specialized handleEvent( type, struct ).
| EVENT_KEY_PRESS : EVENT_KEY_RELEASE; | ||
| event.key = _getKey( deflectEvent.key ); | ||
| channel.processEvent( type, event ); | ||
| return; |
There was a problem hiding this comment.
even though that's what the old code was doing with 'break', I'm wondering it should be 'continue' to handle all pending events?
|
I'm finished with it literally. There seemed to be an amendment in the meantime, but I don't know what you changed there. You either tell me or make new commits to isolate those changes. |
|
No amendment yet, just rebased onto master. |
eile
force-pushed
the
events
branch
3 times, most recently
from
9185aaf
to
efa3411
Compare
eile
force-pushed
the
events
branch
2 times, most recently
from
19a8cf1
to
37ec582
Compare
eile
force-pushed
the
events
branch
4 times, most recently
from
7f6b4e4
to
7fcb167
Compare
|
Not sure it was mentioned why the Qt events have to be clone when reposted (better put it for later reference). |
|
PR contains two of my commits. Rebase again? |
|
+1 otherwise |
|
Retest this please. |
|
+1 again |
Review - do not merge yet