Remove C++03 zombies #304
Merged
Remove C++03 zombies #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have to rebase, I think the first commit was already merged. |
eile
force-pushed
the
master
branch
2 times, most recently
from
76e93e1
to
c34ba83
Compare
hernando
reviewed
Feb 21, 2017
| while (!predicate(_value)) | ||
| _cond.wait(); | ||
| const T _wait(const F& predicate) const | ||
| { |
There was a problem hiding this comment.
Why have you removed the lock free check?
There was a problem hiding this comment.
Premature optimization which would be harder to retain with C++11 primitives.
| @@ -21,99 +21,81 @@ namespace lunchbox | |||
| template <typename T, size_t S> | |||
| MTQueue<T, S>& MTQueue<T, S>::operator=(const MTQueue<T, S>& from) | |||
There was a problem hiding this comment.
Add a move assignment and constructor?
lunchbox/mtQueue.ipp
Outdated
| _maxSize = maxSize; | ||
| _cond.signal(); | ||
| _cond.unlock(); | ||
| _condition.notify_one(); |
eile
force-pushed
the
master
branch
2 times, most recently
from
8d750ff
to
f196472
Compare
tribal-tec
approved these changes
Feb 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.