Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lander's "Set Rotation" should point the craft any way the user wants. #11

Open
Ezriilc opened this issue Jul 15, 2016 · 10 comments
Open
Assignees

Comments

@Ezriilc
Copy link
Owner

Ezriilc commented Jul 15, 2016

If using the Lander with a spaceplane, or horizontally oriented ship, and setting "Set Rotation", it will point the nose of the craft to the sky, as if it were a vertical rocket.

Also, it would be good to add a setting for compass bearing and/or manual vert/horz degrees of rotation.

@Ezriilc Ezriilc self-assigned this Jul 20, 2016
@Ezriilc
Copy link
Owner Author

Ezriilc commented Jul 20, 2016

There should be check/text boxes for options such as which direction to point / which way is up / etc..

@fronbow
Copy link
Collaborator

fronbow commented Dec 22, 2017

I think this is a KSP thing. In the source we point the craft "up" as far as KSP thinks "up" is for the current vessel. I'll do some testing to see if there's another way of orienting a craft.
It may be that we need to check for rockets vs planes and do different ways of up.

@fronbow
Copy link
Collaborator

fronbow commented Dec 23, 2017

I have some ideas on how we might solve this, so today I will mostly be watching KSP in slow motion (breakpoints) and wrapping up xmas pressies!

fronbow added a commit to fronbow/HyperEdit that referenced this issue Jan 1, 2018
Trying to get rid of rogue Latitudes.
Correcting SetToLanded altitude display. See Ezriilc#15
Ezriilc#11 Correcting rotation for planes.
fronbow added a commit that referenced this issue Jan 1, 2018
#11 Set Rotation for aircraft better.
@Ezriilc
Copy link
Owner Author

Ezriilc commented Jan 2, 2018

It has been suggested that we consider a setting to point the craft a certain way on landing. I like the idea, so I've added it here.

@Ezriilc Ezriilc changed the title Lander's "Set Rotation" can't change "Up" for spaceplanes. Lander's "Set Rotation" should point the craft any way the user wants. Jan 2, 2018
@fronbow
Copy link
Collaborator

fronbow commented Jan 2, 2018

I would've made a new issue so we could tag it as a feature request!
Anyhow, I'm curious about what you mean?
Up or Down would be simple enough or do you/they mean setting a direction (0 - 360deg)?

@Ezriilc
Copy link
Owner Author

Ezriilc commented Jan 2, 2018

This issue is already somewhat a suggestion. I assumed this addition would be part of any "fix" for this existing issue. If it turns out that entirely different code/tweaks are needed, then yea, it makes sense to move this to a new issue.

Re: Up/Down/0-359...: Yes!
It would be ideal to have all 3 attitude axes definable, and have some presets like "Current", "Up", "Down", N,S,E,W, etc.. I pictured "Current" being default.

@fronbow
Copy link
Collaborator

fronbow commented Jan 2, 2018

I'll put this on my todo list ;)
It's starting to feel like we need to rethink some parts of the UI (the lander panel could get quite long with this!!)

@Ezriilc
Copy link
Owner Author

Ezriilc commented Jan 2, 2018

I was just thinking the same thing. I assume we can go wider, and/or have tabs/scrolling/whatever...?

@fronbow
Copy link
Collaborator

fronbow commented Jan 2, 2018

Yes, we can go wider, maybe 2+ columns. I know how scrolling works now! Just trying to find stuff on tabs or other ways to lay out controls.

@Ezriilc
Copy link
Owner Author

Ezriilc commented Dec 17, 2018

This issue is related to #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants