This repository has been archived by the owner on Jul 29, 2020. It is now read-only.
Fix govet errors in f5router.go #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Go vet reported a lock being passed by copy. Solution: Remove copying of lock and pass by pointer. Fixes F5Networks#150
amudukutore
reviewed
Apr 4, 2018
| @@ -634,7 +634,7 @@ func (r *F5Router) createResources() bigipResources.PartitionMap { | |||
|
|
|||
| dataGroups := make(map[string]map[string]*bigipResources.InternalDataGroupRecord) | |||
| if r.c.BrokerMode { | |||
| brokerInternalDataGroup := populateBrokerDataGroup(r.bindIDRouteURIPlanNameMap) | |||
| brokerInternalDataGroup := populateBrokerDataGroup(&r.bindIDRouteURIPlanNameMap) | |||
There was a problem hiding this comment.
Good catch! I'm surprised this wasn't manifesting in any of our tests.
amudukutore
approved these changes
Apr 4, 2018
f5yacobucci
added a commit
to f5yacobucci/cf-bigip-ctlr
that referenced
this pull request
Apr 4, 2018
Fix govet errors in f5router.go (cherry picked from commit 927817e)
f5yacobucci
added a commit
that referenced
this pull request
Apr 4, 2018
Merge pull request #151 from f5yacobucci/govet
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Go vet reported a lock being passed by copy.
Solution: Remove copying of lock and pass by pointer.
Fixes #150