Skip to content
This repository has been archived by the owner on Jul 29, 2020. It is now read-only.

Fix govet errors in f5router.go #151

Merged
merged 1 commit into from Apr 4, 2018
Merged

Fix govet errors in f5router.go #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/RELEASE-NOTES.rst
View file
Open in desktop
Expand Up @@ -10,6 +10,7 @@ Added controller name and version to the metadata of certain BIG-IP LTM resource

Bug Fixes
`````````
* :issues:`150` - Fix go vet lock copy error

v1.1.1
------
Expand Down
4 changes: 2 additions & 2 deletions f5router/f5router.go
View file
Open in desktop
Expand Up @@ -591,7 +591,7 @@ func initPartitionData(pm bigipResources.PartitionMap, partition string) {
}

// Populates a data group from the mutexBindIDRouteURIPlanNameMap
func populateBrokerDataGroup(brokerData mutexBindIDRouteURIPlanNameMap) map[string]*bigipResources.InternalDataGroupRecord {
func populateBrokerDataGroup(brokerData *mutexBindIDRouteURIPlanNameMap) map[string]*bigipResources.InternalDataGroupRecord {
dg := make(map[string]*bigipResources.InternalDataGroupRecord)

brokerData.lock.Lock()
Expand Down Expand Up @@ -634,7 +634,7 @@ func (r *F5Router) createResources() bigipResources.PartitionMap {

dataGroups := make(map[string]map[string]*bigipResources.InternalDataGroupRecord)
if r.c.BrokerMode {
brokerInternalDataGroup := populateBrokerDataGroup(r.bindIDRouteURIPlanNameMap)
brokerInternalDataGroup := populateBrokerDataGroup(&r.bindIDRouteURIPlanNameMap)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I'm surprised this wasn't manifesting in any of our tests.

dataGroups[BrokerDataGroupName] = brokerInternalDataGroup
}
dataGroups[InternalDataGroupName] = r.internalDataGroup
Expand Down