Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL verification disabled, without option to enable #133

Closed
dosmanak opened this issue Jun 2, 2017 · 1 comment
Closed

SSL verification disabled, without option to enable #133

dosmanak opened this issue Jun 2, 2017 · 1 comment

Comments

@dosmanak
Copy link

dosmanak commented Jun 2, 2017

On debian stretch I get warnings:
/usr/local/lib/python2.7/dist-packages/urllib3/connectionpool.py:852: InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings InsecureRequestWarning)
I found at https://github.com/F5Networks/f5-icontrol-rest-python/blob/1.0/icontrol/authtoken.py#L98
the request is made with verify=False. It would be nice to be able to change this setting through F5 libraries to be able to verify ssl.
Anyway thank you for great work to make icontrol available from python.

magnuswatn added a commit to magnuswatn/f5-icontrol-rest-python that referenced this issue Jun 3, 2017
Issues:
Fixes F5Networks#133

Problem:
It was not possible for the caller to turn on certificate verification

Analysis:
Makes the verify option from requests available to the caller

Tests:
Added both unit tests and functional testcases to check that the certificate is now correctly checked (when the caller wants)
@dosmanak
Copy link
Author

dosmanak commented Jun 9, 2017

Docs generated with sphinx, but sphinx > 1.5 does not support python 2.6
http://www.sphinx-doc.org/en/stable/changes.html#id20

Drop python 2.6 and 3.3 support

But python3.3 passed.

caphrim007 pushed a commit that referenced this issue Jul 28, 2017
* Added the option to enable SSL verification

Issues:
Fixes #133

Problem:
It was not possible for the caller to turn on certificate verification

Analysis:
Makes the verify option from requests available to the caller

Tests:
Added both unit tests and functional testcases to check that the certificate is now correctly checked (when the caller wants)

* Added missing newline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant