Added the option to enable SSL verification #134
Conversation
Issues: Fixes F5Networks#133 Problem: It was not possible for the caller to turn on certificate verification Analysis: Makes the verify option from requests available to the caller Tests: Added both unit tests and functional testcases to check that the certificate is now correctly checked (when the caller wants)
|
@zancas and @wojtek0806: @magnuswatn has filled out a CLA for us and we can accept his contributions. |
|
What's the status here? Just give me a heads up if there's anything I should change. The failing Travis build is because sphinx/typing have dropped Python 2.6 support. |
|
lgtm |
|
suppose we should fix the travis tests in a follow-up PR to not test on 2.6 anymore. f5-sdk doesn't support 2.6 anymore either |
|
Would it be possible to release a new version with this included? Need it to add the verify functionality to f5-common-python. |
|
@magnuswatn I am going to pressure the release team to do this starting tomorrow |
|
@magnuswatn i believe this is now released with f5-sdk 3.0 |
|
@caphrim007 I'm not sure i understand. Isn't f5-sdk (f5-common-python) another package, which is just dependent on this one? I don't see how a release of f5-sdk is relevant to fixes here? I tried to download a fresh copy of f5-sdk, and I got the old f5-icontrol-rest code. Sorry if I'm missing something obvious here. |
Issues:
Fixes #133
Problem:
It was not possible for the caller to turn on certificate verification
Analysis:
Makes the verify option from requests available to the caller
Tests:
Added both unit tests and functional testcases to check that the certificate is now correctly checked (when the caller wants)