fixes #89 - update README #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think for this repo we need to modify this a bit more to be more clear that this library is not useful for most users and they should be using the f5-sdk instead. We are closer with these changes, but I think we want the first few lines of the README and possibly the repo description to point users to the f5-sdk. |
remove dependency text from README; replaced with directive to use the f5-sdk
|
@swormke - new edits available for review |
|
Ok, this looks much better, but lets just link to the F5Networks/f5-common-python repo on github rather than its docs. Do that in one sentence in bold and I think we have it. |
address review comments from @swormke
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #89
@swormke
What's this change do?
Updates the readme to more clearly state that this repo is a dependency of the f5-common-python repo and that users do not need to install the f5-icontrol-rest-python package separately.
Where should the reviewer start?
review the changes below
Any background context?
Changes have been reviewed and approved by the requestor (Alex A).