Remove __downloadPreviewFromWeb from maps.preview #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs review and testing to make sure I haven't missed anything. |
Closed
|
@Brutus5000 @muellni can one of you have a look over this please? |
|
I'm not very familiar with the client, but I ran the client on this branch and spotted no problems in map previews. |
All map preview calls already use the downloadManager class if maps.preview doesn't find a preview icon. The `__downloadPreviewFromWeb` call is entirely unnecessary and slows down the client because it is synchronous. Fixes FAForever#506
duk3luk3
force-pushed
the
506-fix-webpreview-async
branch
from
43c086b
to
dd852c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All map preview calls already use the downloadManager class if
maps.preview doesn't find a preview icon. The
__downloadPreviewFromWebcall is entirely unnecessary and slows down the client because it is
synchronous.
Fixes #506
issuenum-fix/feature/cleanup-descriptionWhen all builds pass and a maintainer is happy with your PR, the "ready" label will be applied. Please complete these tasks then: