Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double clicking on FAF logo makes the client fullscreen #1075

Closed
Rackover opened this issue Dec 23, 2018 · 1 comment · Fixed by #1818
Closed

Double clicking on FAF logo makes the client fullscreen #1075

Rackover opened this issue Dec 23, 2018 · 1 comment · Fixed by #1818
Assignees
@micheljung
Labels
bug
Milestone
v1.2.0

Comments

@Rackover
Copy link
Member

Not present in 0.8.0
In 0.9.0 upwards double clicking anywhere on the window makes it go fullscreen.
It's great, except when it conflicts with other commands and makes the client fullscreen when it was not intended. Double clicking on the FAF logo is the only way to access connection parameters.
Maybe either make the FAF logo single click, or remove the fullscreen on double click if the click is eaten by another command ?
@micheljung micheljung added the bug label Dec 23, 2018
@1-alex98
Copy link
Member

Double clicking a lot of things make the client full screen

micheljung added a commit that referenced this issue Jul 8, 2020
@micheljung
Native window behavior and design brush-up
ce125f8 
Fixes #444
Fixes #1007
Fixes #1033
Fixes #1038
Fixes #1075
Fixes #1751
Fixes #1760
Fixes #1766
Fixes #1815
Fixes #1816
micheljung added a commit that referenced this issue Jul 8, 2020
@micheljung
Native window behavior and design brush-up
d57951a 
Fixes #1007
Fixes #1033
Fixes #1038
Fixes #1075
Fixes #1751
Fixes #1760
Fixes #1766
Fixes #1815
Fixes #1816
@micheljung micheljung mentioned this issue Jul 9, 2020
Merged
micheljung added a commit that referenced this issue Jul 9, 2020
@micheljung
Native window behavior and design brush-up
97d4597 
Fixes #1007
Fixes #1033
Fixes #1038
Fixes #1075
Fixes #1751
Fixes #1760
Fixes #1766
Fixes #1815
Fixes #1816
micheljung added a commit that referenced this issue Jul 9, 2020
@micheljung
Native window behavior and design brush-up
f09d36f 
Fixes #1007
Fixes #1033
Fixes #1038
Fixes #1075
Fixes #1685
Fixes #1751
Fixes #1760
Fixes #1766
Fixes #1815
Fixes #1816
micheljung added a commit that referenced this issue Jul 9, 2020
@micheljung
Native window behavior and design brush-up
b3048f0 
Fixes #1007
Fixes #1033
Fixes #1038
Fixes #1075
Fixes #1685
Fixes #1751
Fixes #1760
Fixes #1766
Fixes #1815
Fixes #1816
micheljung added a commit that referenced this issue Jul 9, 2020
@micheljung
Native window behavior and design brush-up
ddb3433 
Fixes #1007
Fixes #1033
Fixes #1038
Fixes #1075
Fixes #1685
Fixes #1751
Fixes #1760
Fixes #1766
Fixes #1815
Fixes #1816
micheljung added a commit that referenced this issue Jul 9, 2020
@micheljung
Native window behavior and design brush-up
28fcc6d 
Fixes #1007
Fixes #1033
Fixes #1038
Fixes #1075
Fixes #1685
Fixes #1751
Fixes #1760
Fixes #1766
Fixes #1815
Fixes #1816
micheljung added a commit that referenced this issue Jul 9, 2020
@micheljung
Native window behavior and design brush-up
b5234ed 
Fixes #1007
Fixes #1033
Fixes #1038
Fixes #1075
Fixes #1685
Fixes #1751
Fixes #1760
Fixes #1766
Fixes #1815
Fixes #1816
Fixes #1817
micheljung added a commit that referenced this issue Jul 9, 2020
@micheljung
Native window behavior and design brush-up
c939e9c 
Fixes #1007
Fixes #1033
Fixes #1038
Fixes #1075
Fixes #1685
Fixes #1751
Fixes #1760
Fixes #1766
Fixes #1815
Fixes #1816
Fixes #1817
micheljung added a commit that referenced this issue Jul 9, 2020
@micheljung
Native window behavior and design brush-up
f3aaf9d 
Fixes #1007
Fixes #1033
Fixes #1038
Fixes #1075
Fixes #1685
Fixes #1751
Fixes #1760
Fixes #1766
Fixes #1815
Fixes #1816
Fixes #1817
micheljung added a commit that referenced this issue Jul 9, 2020
@micheljung
Native window behavior and design brush-up
181c3eb 
Fixes #1007
Fixes #1033
Fixes #1038
Fixes #1075
Fixes #1685
Fixes #1751
Fixes #1760
Fixes #1766
Fixes #1815
Fixes #1816
Fixes #1817
micheljung added a commit that referenced this issue Jul 10, 2020
@micheljung
Native window behavior and design brush-up
f5ff9bf 
Fixes #1007
Fixes #1033
Fixes #1038
Fixes #1075
Fixes #1685
Fixes #1751
Fixes #1760
Fixes #1766
Fixes #1815
Fixes #1816
Fixes #1817
Fixes #1821
@micheljung micheljung self-assigned this Jul 10, 2020
1-alex98 pushed a commit that referenced this issue Jul 17, 2020
@micheljung @1-alex98
Native window behavior and design brush-up
af8d112 
Fixes #1007
Fixes #1033
Fixes #1038
Fixes #1075
Fixes #1685
Fixes #1751
Fixes #1760
Fixes #1766
Fixes #1815
Fixes #1816
Fixes #1817
Fixes #1821
micheljung added a commit that referenced this issue Jul 25, 2020
@micheljung
Native window behavior and design brush-up
6133f3b 
Fixes #1007
Fixes #1033
Fixes #1038
Fixes #1075
Fixes #1685
Fixes #1751
Fixes #1760
Fixes #1766
Fixes #1815
Fixes #1816
Fixes #1817
Fixes #1821
1-alex98 pushed a commit that referenced this issue Aug 19, 2020
@micheljung @1-alex98
Native window behavior and design brush-up
d58b41a 
Fixes #1007
Fixes #1033
Fixes #1038
Fixes #1075
Fixes #1685
Fixes #1751
Fixes #1760
Fixes #1766
Fixes #1815
Fixes #1816
Fixes #1817
Fixes #1821
1-alex98 added a commit that referenced this issue Aug 27, 2020
@micheljung @1-alex98 @Sheikah45
Native window behavior and design brush-up (#1818)
a672268 
Fixes #1007
Fixes #1033
Fixes #1038
Fixes #1075
Fixes #1685
Fixes #1751
Fixes #1760
Fixes #1766
Fixes #1815
Fixes #1816
Fixes #1817
Fixes #1821

Co-authored-by: alexander <alexander.von.trostorff@gmail.com>
Co-authored-by: Sheikah45 <Sheikah450@gmail.com>
@1-alex98 1-alex98 added this to the v1.2.0 milestone Aug 27, 2020
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this issue Apr 15, 2022
@micheljung @1-alex98 @Sheikah45
Native window behavior and design brush-up (FAForever#1818)
86986f5 
Fixes FAForever#1007
Fixes FAForever#1033
Fixes FAForever#1038
Fixes FAForever#1075
Fixes FAForever#1685
Fixes FAForever#1751
Fixes FAForever#1760
Fixes FAForever#1766
Fixes FAForever#1815
Fixes FAForever#1816
Fixes FAForever#1817
Fixes FAForever#1821

Co-authored-by: alexander <alexander.von.trostorff@gmail.com>
Co-authored-by: Sheikah45 <Sheikah450@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@micheljung micheljung

Labels
bug
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

Native window behavior and design brush-up FAForever/downlords-faf-client
3 participants
@micheljung @1-alex98 @Rackover