Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set some kind of min size for the stage #444

Closed
1-alex98 opened this issue Dec 16, 2016 · 4 comments
Closed

Set some kind of min size for the stage #444

1-alex98 opened this issue Dec 16, 2016 · 4 comments

Comments

@1-alex98
Copy link
Member

1-alex98 commented Dec 16, 2016

error


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

1-alex98 added a commit that referenced this issue Dec 18, 2016
@1-alex98 1-alex98 self-assigned this Dec 18, 2016
@1-alex98 1-alex98 reopened this Jan 18, 2017
@1-alex98
Copy link
Member Author

grafik

@Bearnn
Copy link

Bearnn commented May 7, 2017

Thought I'd have a look at this:

In the faforever/client/fx/WindowController.java there is this paragraph of code under the onWindowResize(MouseEvent event) method:

    if (newHeight < stage.getMinHeight()) {
      newHeight = stage.getMinHeight();
    }
    if (newWidth < stage.getMinWidth()) {
      newWidth = stage.getMinWidth();
    }

However I can't find anywhere where the setMinWidth and setMinHeight is used. Maybe I'm just not searching the code properly but thought I'd mention it.

Any advice would be appreciated!

@micheljung
Copy link
Member

micheljung commented May 8, 2017

main.fxml has minHeight and minWidth set, but the stage (=window) was allowed to resized to be smaller than that. The pane of main.fxml then just got "cropped" instead of getting shrinked. This is why I added the code above (which, btw, I reformatted using ```)

Not sure why it isn't working, and not sure if it's really a beginner task then.. :)

@1-alex98 1-alex98 removed their assignment Oct 1, 2017
@micheljung micheljung added enhancement and removed bug labels May 1, 2018
micheljung added a commit that referenced this issue Jul 8, 2020
micheljung added a commit that referenced this issue Jul 8, 2020
Fixes #444
Fixes #1007
Fixes #1033
Fixes #1038
Fixes #1075
Fixes #1751
Fixes #1760
Fixes #1766
Fixes #1815
Fixes #1816
@micheljung
Copy link
Member

I don't like applications that prevent me to resize them as I like. If that's what the user wants, he should be able to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants