Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Periodically verify game location settings #1100

Closed
Askaholic opened this issue Jan 23, 2019 · 1 comment
Closed

Periodically verify game location settings #1100

Askaholic opened this issue Jan 23, 2019 · 1 comment
Milestone

Comments

@Askaholic
Copy link
Collaborator

Askaholic commented Jan 23, 2019

I recently had the issue that my game location was configured wrong because it used to be installed on one drive, but then was moved to a different drive. The Supreme Commander Forged Alliance folder still existed, but it only had the maps folder left. Everything else including bin got deleted.

The result is that when you try to launch a game, the client does it's usual update and download map stuff, but then just stops with no sign of an error or anything. (It logs the exception which is how I discovered that this is what was happening).

It would be nice if:

  • a). There were some error handling for File IO (because lets be honest, we can't seriously expect file io to never fail)
  • b). There were an error message indicating that the game path was set incorrectly or was no longer valid. Checks for this error could happen on startup and notify the user to fix their settings, or even be triggered from the error handling in part a. Better than just displaying an error, this could even grey out the host/join game buttons so that the user isn't fooled into thinking everything is ok.

To my pleasant surprise the client already implements some validity checks when setting the game path initially which would have been part c.

@Katharsas
Copy link
Collaborator

@1-alex98 1-alex98 added this to the v1.1.4 milestone Mar 11, 2020
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this issue Apr 15, 2022
Fixes FAForever#1594

Fixes FAForever#1355

Fixes FAForever#1100

Fixes FAForever#1614  

* fixed hash function for supcom.exe (FAForever#1614)

Co-authored-by: Slothologist <rfeldh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants