Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate map rating/review #1581

Closed
badbwoi opened this issue Feb 16, 2020 · 5 comments · Fixed by #2055
Closed

migrate map rating/review #1581

badbwoi opened this issue Feb 16, 2020 · 5 comments · Fixed by #2055
Milestone

Comments

@badbwoi
Copy link

badbwoi commented Feb 16, 2020

Hello,
I was wondering why the map rating/review is not migrated when u upload a new map version?
image

@axel1200:

It is not a bug because it was intended on the other hand it is suboptimal i guess

Are there any problem I can't see? Because it would be very nice if the map rating/review could be migrated.

@Brutus5000
Copy link
Member

This is a difficult topic with no obvious solution.

Why is there a new version? Because something was changed. Usually bugs fixed or quality improved. Thus old comments may get outdated due to this. Do you want to see comments of an outdated version while the points mentioned there are already fixed? (Same applies for the calculated 5-star rating btw.)

So the best way would be to show all comments, but make a badge on comments to older version that this commented belongs to an older version.

@bukajsytlos
Copy link
Member

bukajsytlos commented Feb 16, 2020 via email

@badbwoi
Copy link
Author

badbwoi commented Apr 10, 2020

I like Brutus idea as well, sounds like a lovely solution.

@micheljung
Copy link
Member

@Brutus5000 when I designed the reviews, I had this issue in mind and I'm pretty sure the API, at least the database, is able to provide both, reviews per version as well as aggregated ones?

@1-alex98
Copy link
Member

And again it is not a client issue right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants