Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#1581 migrate reviews on maps and mods #2055

Merged
merged 7 commits into from Nov 29, 2020

Conversation

Sheikah45
Copy link
Member

@Sheikah45 Sheikah45 commented Nov 28, 2020

Fixes #1581
Fixes #1348

How the reviews look with the version label
Screenshot (162)

Showing how even recently updated versions keep the reviews.
Screenshot (161)

@Sheikah45 Sheikah45 changed the title Feature/#1581 migrate reviews Feature/#1581 migrate reviews on maps and mods Nov 28, 2020
@Brutus5000
Copy link
Member

Brutus5000 commented Nov 28, 2020

The current version should be highlighted with an additional badge or be called "current version" or something similar

@Sheikah45
Copy link
Member Author

The current version should be highlighted with an additional badge or be called "current version" or something similar

Good idea

Comment on lines +150 to +151
reviewsController.setCanWriteReview(modService.isModInstalled(modVersion.getUid())
&& !modVersion.getMod().getAuthor().equals(player.getUsername()));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sneaky sneaky ;-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested by our creative councilor

@Sheikah45 Sheikah45 merged commit b04a7e6 into develop Nov 29, 2020
@Sheikah45 Sheikah45 deleted the feature/#1581-migrate-reviews branch January 12, 2021 01:31
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this pull request Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate map rating/review [Feature Request] Display reviews and score for previous versions of mods
2 participants