Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter breaks chat layout #1618

Closed
FemtoZetta opened this issue Mar 14, 2020 · 5 comments · Fixed by #1872
Closed

Filter breaks chat layout #1618

FemtoZetta opened this issue Mar 14, 2020 · 5 comments · Fixed by #1872
Labels
bug
Milestone
v1.2.1

Comments

@FemtoZetta
Copy link
Contributor

Using the filter in chat on the right breaks the chat layout. Screenshots are provided to make it more clear.

before filter
after filter
@FemtoZetta FemtoZetta added the bug label Mar 14, 2020
@FemtoZetta FemtoZetta changed the title filter breaks chat layout Filter breaks chat layout Mar 14, 2020
@1-alex98
Copy link
Member

where is the break?

@1-alex98
Copy link
Member

You still want the categories?

@FemtoZetta
Copy link
Contributor Author

FemtoZetta commented Mar 14, 2020 •
edited

Yes, that's after I "erased" the filter, so there's nothing to filter anymore. I don't need it during filtering, but afterwards, when not filtering anything anymore, it would be nice if it went back to the default.

@1-alex98
Copy link
Member

ok

@FemtoZetta
Copy link
Contributor Author

To add a bit: I'm talking about the filter for rating and clan (from the white icon)... The normal filter where you can just filter for name doesn't remove the categories (and it actually brings them back after they were removed by the other filter).
So maybe you can use the normal filter as a reference.

Sheikah45 added a commit to Sheikah45/downlords-faf-client that referenced this issue Aug 29, 2020
@Sheikah45
Maintain chat user categories when filtering
2ad66ae 
Fixes FAForever#1618

Use a single filter function for all filters and maintain categories during filtering
@Sheikah45 Sheikah45 mentioned this issue Aug 29, 2020
Merged
1-alex98 pushed a commit that referenced this issue Sep 11, 2020
@Sheikah45
Maintain chat user categories when filtering
208e5dc 
Use a single filter function for all filters and maintain categories during filtering
Fixes #1618
@micheljung micheljung added this to the v1.2.1 milestone Sep 24, 2020
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this issue Apr 15, 2022
@Sheikah45
Maintain chat user categories when filtering
b6e59b6 
Use a single filter function for all filters and maintain categories during filtering
Fixes FAForever#1618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.2.1
Development

Successfully merging a pull request may close this issue.

Maintain chat user categories when filtering Sheikah45/downlords-faf-client
3 participants
@micheljung @1-alex98 @FemtoZetta