Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintain chat user categories when filtering #1872

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Maintain chat user categories when filtering #1872

merged 1 commit into from
Sep 11, 2020
+5 −21

Conversation

Sheikah45
Copy link
Member

Fixes #1618

Use a single filter function for all filters and maintain categories during filtering

@Sheikah45
Maintain chat user categories when filtering
2ad66ae 
Fixes FAForever#1618

Use a single filter function for all filters and maintain categories during filtering
1-alex98
1-alex98 approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@1-alex98 1-alex98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good gotta test that

Brutus5000
Brutus5000 approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@Brutus5000 Brutus5000 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it, works.

@1-alex98 1-alex98 merged commit 208e5dc into FAForever:develop Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brutus5000 Brutus5000 Brutus5000 approved these changes

@1-alex98 1-alex98 1-alex98 approved these changes

@micheljung micheljung Awaiting requested review from micheljung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter breaks chat layout
3 participants
@Sheikah45 @Brutus5000 @1-alex98