Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mapping for faction icons in replay details #1668

Closed
FemtoZetta opened this issue Apr 4, 2020 · 1 comment · Fixed by #1669
Closed

Fix mapping for faction icons in replay details #1668

FemtoZetta opened this issue Apr 4, 2020 · 1 comment · Fixed by #1669
Labels
bug
Milestone
v1.1.6

Comments

@FemtoZetta
Copy link
Contributor

Factions are currently mapped as
1 = Aeon
2 = Cybran
3 = UEF
4 = Seraphim
but server uses
1 = UEF
2 = Aeon
3 = Cybran
4 = Seraphim.
Maybe requires a new enum, if changing the current one breaks functionalities.
@FemtoZetta FemtoZetta added the bug label Apr 4, 2020
@Askaholic
Copy link
Collaborator

You can also verify what the game uses here:
https://github.com/FAForever/fa/blob/720a72f5eca5330ba497320a618a57c7b981cda2/lua/factions.lua#L106

The number is the order in which it appears in that table (remembering that lua tables are 1 indexed)

FemtoZetta added a commit that referenced this issue Apr 5, 2020
@FemtoZetta
#1668-fix-faction-mapping
3873895 
fixes #1668:
-changes the order in the Faction enum so it reflects the order the server reports in
-added a comment to explain why the order is important, since that is not intuitive
-that fixes the icons in the replay overview being wrong for everything but Sera
@FemtoZetta FemtoZetta mentioned this issue Apr 5, 2020
Merged
1-alex98 pushed a commit that referenced this issue Apr 6, 2020
@FemtoZetta
#1668-fix-faction-mapping (#1669)
b37c701 
fixes #1668:
-changes the order in the Faction enum so it reflects the order the server reports in
-added a comment to explain why the order is important, since that is not intuitive
-that fixes the icons in the replay overview being wrong for everything but Sera
@1-alex98 1-alex98 added this to the v1.1.6 milestone Apr 20, 2020
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this issue Apr 15, 2022
@FemtoZetta
FAForever#1668-fix-faction-mapping (FAForever#1669)
fecdc49 
fixes FAForever#1668:
-changes the order in the Faction enum so it reflects the order the server reports in
-added a comment to explain why the order is important, since that is not intuitive
-that fixes the icons in the replay overview being wrong for everything but Sera
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.1.6
Development

Successfully merging a pull request may close this issue.

#1668-fix-faction-mapping FAForever/downlords-faf-client
3 participants
@Askaholic @1-alex98 @FemtoZetta