#1668-fix-faction-mapping #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #1668: -changes the order in the Faction enum so it reflects the order the server reports in -added a comment to explain why the order is important, since that is not intuitive -that fixes the icons in the replay overview being wrong for everything but Sera
|
Please check where else this enum is used!!! |
|
is this definately right order? in api aeon is first |
|
@axel1200 I didn't find anything that didn't work. I tested 1v1 ladder, coop and custom game. The ordinal functions of the enum are actually never used. @bukajsytlos Show me one example where the API does report Aeon as 1 please. |
|
@bukajsytlos the api's order s wrong |
1-alex98
approved these changes
Apr 6, 2020
mrchris2000
pushed a commit
to mrchris2000/downlords-faf-client
that referenced
this pull request
Apr 15, 2022
fixes FAForever#1668: -changes the order in the Faction enum so it reflects the order the server reports in -added a comment to explain why the order is important, since that is not intuitive -that fixes the icons in the replay overview being wrong for everything but Sera
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1668:
-changes the order in the Faction enum so it reflects the order the server reports in
-added a comment to explain why the order is important, since that is not intuitive
-that fixes the icons in the replay overview being wrong for everything but Sera