Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup windows have several annoyances #1733

Closed
BlackYps opened this issue May 29, 2020 · 5 comments
Closed

Popup windows have several annoyances #1733

BlackYps opened this issue May 29, 2020 · 5 comments

Comments

@BlackYps
Copy link
Collaborator

BlackYps commented May 29, 2020

The popup windows (Create Game, Map Details, Mod Details, Replay Details) have several visual issues:

  • They are always 50px from each border without any limitation, which makes them ridicilously large in fullscreen and destrys the layout when the window is too small
  • The Create Game dialog has a unnecessary headline and no proper close button
  • also the rating field and the "Min." text are the wrong way around
  • The buttons in the Map Details collide with the title
  • "Description" headline is unnecessary and doesn't exist in the equivalent Mod Details anyway.
  • Install button in Mod Details has the wrong button style
BlackYps added a commit to BlackYps/downlords-faf-client that referenced this issue May 29, 2020
@Sheikah45
Copy link
Member

does this still apply? The PR was closed saying not needed

@BlackYps
Copy link
Collaborator Author

This still applies. I just never finished it to properly use the JFXDialog. You are welcome to finish the PR. I will focus more on tmm and the league system.

@1-alex98
Copy link
Member

no it does not apply any more... @BlackYps have a look at develop. We are not using JFX anymore at all

@BlackYps
Copy link
Collaborator Author

Well the pr does not apply anymore, but the issue still persists. Some of these can be fixed by simply changing the layout in the fxml files, so these should be relatively easy to reuse.

@Sheikah45
Copy link
Member

I think most of these have been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants