Make popup windows more consistent #1716
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing CI |
BlackYps
force-pushed
the
feature/popup-windows
branch
from
4c40128
to
d3ddfea
Compare
|
Fixes #1733 |
1-alex98
requested changes
May 30, 2020
| @@ -179,7 +179,7 @@ public void initialize() { | |||
| } | |||
|
|
|||
| public void onCloseButtonClicked() { | |||
| onCloseButtonClickedListener.run(); | |||
| getRoot().setVisible(false); | |||
There was a problem hiding this comment.
Don't think that is sufficent to effectively close it
There was a problem hiding this comment.
Previously this listener was created when the JFXDialog was created. I guess it was needed to make the dialog disappear properly / to trigger the close animation.
Now it just hides and reveals the create game window. It works in the same way in the mod and map details.
If you want to have it "more" closed I need you to go into more detail how you want to achieve that.
Don't know if it's worth the effort just to unload a few elements and one map preview picture from memory, though.
|
We wanna use jfx on vault not drop jfx in create game dialog |
|
outdated and no longer needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings the style of the popup windows (map, mod, and replay detail and create game) more in line with each other and fixes minor UI Issues.
All windows keep sensible min and max sizes and hover in the middle of the screen.
The Create Game window now has a proper cancel button and no superfluous title anymore
"Min" is now in front of the text field instead of behind
Map detail buttons are lower so they don't crash with the map name
"Description" removed
Mod detail install button is now a highlighted button
