Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate when game title is missing #1813

Closed
micheljung opened this issue Jul 8, 2020 · 1 comment · Fixed by #1819
Closed

Indicate when game title is missing #1813

micheljung opened this issue Jul 8, 2020 · 1 comment · Fixed by #1819
Labels
beginner-friendly enhancement
Milestone
v1.1.9

Comments

@micheljung
Copy link
Member

A missing title in the "Create Game" dialog has led to confusion. The client should highlight the input field when the title is missing.
@TobiasJacob TobiasJacob mentioned this issue Jul 9, 2020
Merged
@TobiasJacob
Copy link
Contributor

Hello @micheljung,

I added a pull request to fix that issue. It's my first pull request, so I hope everything is ok

1-alex98 pushed a commit that referenced this issue Jul 17, 2020
@TobiasJacob
Warn m issing game title
0ff1e7a 
Fixes #1813
@1-alex98 1-alex98 added this to the v1.1.9 milestone Jul 21, 2020
mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this issue Apr 15, 2022
@TobiasJacob
Warn m issing game title
e399eca 
Fixes FAForever#1813
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner-friendly enhancement
Projects
None yet
Milestone
v1.1.9
Development

Successfully merging a pull request may close this issue.

Create game title text field changes border to red if not filled out
3 participants
@micheljung @TobiasJacob @1-alex98