Create game title text field changes border to red if not filled out #1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Tobias and thanks for contributing! I'll review your PR |
micheljung
requested changes
Jul 10, 2020
src/main/resources/theme/style.css
Outdated
| @@ -959,6 +959,7 @@ | |||
|
|
|||
| .game-title-input { | |||
| -fx-font-size: 0.8cm; | |||
| -fx-prompt-text-fill: -fx-light-text-color; | |||
There was a problem hiding this comment.
I think this is obsolete then
| @@ -220,6 +222,15 @@ private void init() { | |||
| ); | |||
| } | |||
|
|
|||
| private void adjustCreateGameButtonBackgroundColor(String newValue) { | |||
| if (Strings.isNullOrEmpty(newValue)) { | |||
| // titleTextField.setBackground(new Background(new BackgroundFill(Paint.valueOf("FF0000"), CornerRadii.EMPTY, Insets.EMPTY))); | |||
TobiasJacob
changed the title
|
Hello @micheljung, I agree with your suggestions and implemented them |
1-alex98
requested changes
Jul 11, 2020
|
Hello @axel1200, I hope this is implemented correctly |
1-alex98
approved these changes
Jul 14, 2020
1-alex98
approved these changes
Jul 17, 2020
|
Looks strange but well somebody is someday gonna come up with a prettier way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1813
I'm new in FAF development, so I hope the implementation is ok. It changes the background color of the title text-field of the create game page to red to attract more attention if it's empty.