Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

map veto for ladder #2319

Open
loxpooig opened this issue Aug 4, 2021 · 1 comment
Open

map veto for ladder #2319

loxpooig opened this issue Aug 4, 2021 · 1 comment

Comments

@loxpooig
Copy link

loxpooig commented Aug 4, 2021

Hello,
today i was thinking that players should be allowed to veto ban at least 1 or 2 maps before playing ladder.. that's because somethimes at the idea that I have to play for example open palms for the 1000th time I'm just "ok also today I will play ladder tomorrow"

This could incentivate a lot the increase of ladder players.. at least in my case! but I'm sure there are a lot of you that are like "at the idea that i could have to play that map.. naah i'll just play teamgames.."

I understood that this is not the first time we talk about this in FAF, but as far as I discovered nobody as ever attempt to code it. If I had known something about that I would have for sure tried to implement it myself, but I have no idea how to start.

So I'm opening this project, if anybody has the willingness to dedicate some time for it please let me know! Thank you
@Sheikah45
Copy link
Member

With the creation of the team matchmaker this got much more complicated to handle. And has not seen much dev traction in terms of will to implement so closing for now.

@Sheikah45 Sheikah45 reopened this Feb 13, 2024
K-ETFreeman added a commit to K-ETFreeman/downlords-faf-client that referenced this issue Mar 15, 2024
@K-ETFreeman
FAForever#2319 Summoning popup instead of searching mappool in the vault
72feecc
K-ETFreeman added a commit to K-ETFreeman/downlords-faf-client that referenced this issue Mar 15, 2024
@K-ETFreeman
FAForever#2319 Adjusting mapping of MapPoolAssignments
b7d9dc4
K-ETFreeman added a commit to K-ETFreeman/downlords-faf-client that referenced this issue Mar 15, 2024
@K-ETFreeman
FAForever#2319 Adjusted API interaction
7516c06
K-ETFreeman added a commit to K-ETFreeman/downlords-faf-client that referenced this issue Mar 15, 2024
@K-ETFreeman
FAForever#2319 Maplist as Popup implemented
a08c046
K-ETFreeman added a commit to K-ETFreeman/downlords-faf-client that referenced this issue Mar 15, 2024
@K-ETFreeman
FAForever#2319 Deprecated test removed
12aaf8c
K-ETFreeman added a commit to K-ETFreeman/downlords-faf-client that referenced this issue Apr 15, 2024
@K-ETFreeman
Merge branch 'develop' into feature/FAForever#2319-veto-system
da1b451
Sheikah45 pushed a commit to K-ETFreeman/downlords-faf-client that referenced this issue Apr 21, 2024
@K-ETFreeman @Sheikah45
FAForever#2319 Summoning popup instead of searching mappool in the vault
5e625ec
Sheikah45 pushed a commit to K-ETFreeman/downlords-faf-client that referenced this issue Apr 21, 2024
@K-ETFreeman @Sheikah45
FAForever#2319 Adjusting mapping of MapPoolAssignments
85741e6
Sheikah45 pushed a commit to K-ETFreeman/downlords-faf-client that referenced this issue Apr 21, 2024
@K-ETFreeman @Sheikah45
FAForever#2319 Adjusted API interaction
be8f3bd
Sheikah45 pushed a commit to K-ETFreeman/downlords-faf-client that referenced this issue Apr 21, 2024
@K-ETFreeman @Sheikah45
FAForever#2319 Maplist as Popup implemented
d8e349c
Sheikah45 pushed a commit to K-ETFreeman/downlords-faf-client that referenced this issue Apr 21, 2024
@K-ETFreeman @Sheikah45
FAForever#2319 Deprecated test removed
9d027ec
Sheikah45 pushed a commit that referenced this issue Apr 22, 2024
@K-ETFreeman
Feature/#2319 veto system: simple maplist popup (#3151)
ac45f8d
@K-ETFreeman K-ETFreeman mentioned this issue Apr 27, 2024
Open
K-ETFreeman added a commit to K-ETFreeman/downlords-faf-client that referenced this issue Jun 3, 2024
@K-ETFreeman
FAForever#2319 Adjusting mapping of MapPoolAssignments
747facf 
# Conflicts:
#	src/main/java/com/faforever/client/domain/api/MatchmakerQueueMapPool.java
K-ETFreeman added a commit to K-ETFreeman/downlords-faf-client that referenced this issue Jun 3, 2024
@K-ETFreeman
FAForever#2319 Adjusted API interaction
679af12 
# Conflicts:
#	src/main/java/com/faforever/client/map/MapService.java
#	src/test/java/com/faforever/client/map/MapServiceTest.java
K-ETFreeman added a commit to K-ETFreeman/downlords-faf-client that referenced this issue Jun 3, 2024
@K-ETFreeman
FAForever#2319 Maplist as Popup implemented
089179e 
# Conflicts:
#	src/main/java/com/faforever/client/teammatchmaking/TeamMatchmakingController.java
#	src/main/java/com/faforever/client/teammatchmaking/TeamMatchmakingMapListController.java
#	src/main/java/com/faforever/client/teammatchmaking/TeamMatchmakingMapTileController.java
#	src/main/resources/theme/play/teammatchmaking/matchmaking_maplist_popup.fxml
#	src/main/resources/theme/style.css
K-ETFreeman added a commit to K-ETFreeman/downlords-faf-client that referenced this issue Jun 3, 2024
@K-ETFreeman
Merge branch 'feature/FAForever#2319-veto-system' of https://github.c…
fc7e6fe 
…om/K-ETFreeman/downlords-faf-client into feature/FAForever#2319-veto-system
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Sheikah45 @loxpooig