Fix possible memory leak in CSS Classes of cells #2524
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I connected the profiler to the client.
As you can see from the graph, memory consumption increases dramatically during each minute, until the garbage collector starts its work. It looks like a memory leak.
After analyzing the code, I came to the conclusion that the
styleClasses
object is not a hash collection, which is whystyleClasses
contains many identical class names, which in turn triggers many monotonous actions (unexplained CPU spikes)Before fix:
After fix: