Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more sort options #2729

Merged
merged 4 commits into from
Jun 19, 2022

Conversation

hahn-kev
Copy link
Contributor

Currently you can only sort by name in mod and map search. This change enables sorting by additional properties.

In making this change I noticed that if I just come to the map vault and change the sort by then the search button is still disabled, but if I want to search all maps but with a custom sort by then I'd like the search button enabled. This change will also enable the search button when it's not the first (or default) search option.

@codecov
Copy link

codecov bot commented Jun 18, 2022

Codecov Report

Merging #2729 (30e1b60) into develop (5b88f72) will decrease coverage by 0.01%.
The diff coverage is 88.88%.

@@              Coverage Diff              @@
##             develop    #2729      +/-   ##
=============================================
- Coverage      65.16%   65.14%   -0.02%     
- Complexity      4835     4839       +4     
=============================================
  Files            521      522       +1     
  Lines          20029    20045      +16     
  Branches        1147     1149       +2     
=============================================
+ Hits           13051    13058       +7     
- Misses          6325     6332       +7     
- Partials         653      655       +2     
Impacted Files Coverage Δ
...aforever/client/vault/search/SearchController.java 55.83% <0.00%> (ø)
...rever/client/query/SearchablePropertyMappings.java 96.55% <100.00%> (ø)
...com/faforever/client/fa/ForgedAllianceService.java 84.61% <0.00%> (-1.33%) ⬇️
...main/java/com/faforever/client/map/MapService.java 74.84% <0.00%> (-0.62%) ⬇️
.../java/com/faforever/client/steam/SteamService.java 56.25% <0.00%> (ø)
...ver/client/discord/DiscordRichPresenceService.java 20.68% <0.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b88f72...30e1b60. Read the comment docs.

Copy link
Member

@Sheikah45 Sheikah45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the most part this is good although the binding change is confusing. I left more details at the code point.

@Sheikah45 Sheikah45 merged commit 6edea1e into FAForever:develop Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants