-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable more sort options #2729
Enable more sort options #2729
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2729 +/- ##
=============================================
- Coverage 65.16% 65.14% -0.02%
- Complexity 4835 4839 +4
=============================================
Files 521 522 +1
Lines 20029 20045 +16
Branches 1147 1149 +2
=============================================
+ Hits 13051 13058 +7
- Misses 6325 6332 +7
- Partials 653 655 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the most part this is good although the binding change is confusing. I left more details at the code point.
Currently you can only sort by name in mod and map search. This change enables sorting by additional properties.
In making this change I noticed that if I just come to the map vault and change the sort by then the search button is still disabled, but if I want to search all maps but with a custom sort by then I'd like the search button enabled. This change will also enable the search button when it's not the first (or default) search option.