Fix disappearance of players in the team list

[Marc-Spector]

Closes #2678

It happens when the player leaves #aeolus channel

[Marc-Spector]

I see no reason to remove players from the map. It won't get any worse.

[Marc-Spector]

damn it...

[codecov]

Codecov Report

Merging #2867 (ae62d85) into develop (46507ac) will increase coverage by 0.00%.
The diff coverage is 92.30%.

❗ Current head ae62d85 differs from pull request most recent head 96cd9fd. Consider uploading reports for the commit 96cd9fd to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             develop    #2867   +/-   ##
==========================================
  Coverage      65.43%   65.44%           
+ Complexity      5095     5094    -1     
==========================================
  Files            553      553           
  Lines          20794    20793    -1     
  Branches        1167     1166    -1     
==========================================
+ Hits           13606    13607    +1     
+ Misses          6505     6503    -2     
  Partials         683      683           

Impacted Files	Coverage Δ
...faforever/client/player/FriendOfflineNotifier.java	21.42% <0.00%> (ø)
...a/com/faforever/client/chat/KittehChatService.java	71.17% <100.00%> (-0.11%)	⬇️
...om/faforever/client/player/PlayerOfflineEvent.java	100.00% <100.00%> (+50.00%)	⬆️
...ava/com/faforever/client/player/PlayerService.java	67.52% <100.00%> (+0.68%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46507ac...96cd9fd. Read the comment docs.

[Sheikah45]

Wouldn't this potentially lead to a memory leak as players are only added and never removed from the map?

[Marc-Spector]

It's possible. I need to find another solution. My change is not suitable as it breaks a notification that a friend has logged into the client.