Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition of matchmaker state #2932

Merged
merged 1 commit into from
Mar 4, 2023

Conversation

Sheikah45
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Mar 4, 2023

Codecov Report

Merging #2932 (1a376a5) into develop (1613daa) will decrease coverage by 0.02%.
The diff coverage is 82.27%.

❗ Current head 1a376a5 differs from pull request most recent head 3748675. Consider uploading reports for the commit 3748675 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2932      +/-   ##
=============================================
- Coverage      64.34%   64.32%   -0.02%     
+ Complexity      4912     4910       -2     
=============================================
  Files            556      556              
  Lines          20323    20329       +6     
  Branches        1100     1101       +1     
=============================================
+ Hits           13076    13077       +1     
- Misses          6614     6619       +5     
  Partials         633      633              
Impacted Files Coverage Δ
...in/java/com/faforever/client/game/GameService.java 64.40% <75.00%> (-0.53%) ⬇️
...client/teammatchmaking/TeamMatchmakingService.java 86.80% <88.88%> (+0.19%) ⬆️
...ent/teammatchmaking/TeamMatchmakingController.java 95.13% <100.00%> (ø)
...java/com/faforever/client/util/ConcurrentUtil.java 66.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1613daa...3748675. Read the comment docs.

@Sheikah45 Sheikah45 merged commit 1139d8d into develop Mar 4, 2023
@Sheikah45 Sheikah45 deleted the bugfix/matchmaker-race-condition branch March 4, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant