Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use websockets for lobby connection #3037

Merged
merged 7 commits into from
Oct 14, 2023
Merged

Use websockets for lobby connection #3037

merged 7 commits into from
Oct 14, 2023

Conversation

Sheikah45
Copy link
Member

No description provided.

@Sheikah45 Sheikah45 temporarily deployed to deploy October 12, 2023 11:20 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #3037 (ab5eafa) into develop (ef64c1d) will increase coverage by 0.03%.
The diff coverage is 72.41%.

❗ Current head ab5eafa differs from pull request most recent head 567b606. Consider uploading reports for the commit 567b606 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3037      +/-   ##
=============================================
+ Coverage      59.29%   59.32%   +0.03%     
- Complexity      4482     4492      +10     
=============================================
  Files            553      554       +1     
  Lines          20166    20167       +1     
  Branches        1037     1038       +1     
=============================================
+ Hits           11958    11965       +7     
+ Misses          7661     7653       -8     
- Partials         547      549       +2     
Files Coverage Δ
.../java/com/faforever/client/api/FafApiAccessor.java 93.54% <100.00%> (-0.13%) ⬇️
...va/com/faforever/client/login/LoginController.java 87.35% <100.00%> (-0.15%) ⬇️
.../java/com/faforever/client/remote/LobbyAccess.java 100.00% <100.00%> (ø)
...a/com/faforever/client/config/WebClientConfig.java 0.00% <0.00%> (ø)
...m/faforever/client/update/ClientConfiguration.java 40.62% <50.00%> (-2.71%) ⬇️
...com/faforever/client/remote/FafServerAccessor.java 80.31% <84.61%> (+0.15%) ⬆️
.../com/faforever/client/config/ClientProperties.java 52.41% <42.85%> (-2.06%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef64c1d...567b606. Read the comment docs.

@Sheikah45 Sheikah45 temporarily deployed to deploy October 13, 2023 23:25 — with GitHub Actions Inactive
@Sheikah45 Sheikah45 temporarily deployed to deploy October 14, 2023 16:25 — with GitHub Actions Inactive
@Sheikah45 Sheikah45 merged commit 201a74f into develop Oct 14, 2023
6 of 7 checks passed
@Sheikah45 Sheikah45 deleted the feature/websocket branch October 14, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant