Skip to content

Commit

Permalink
Add missing key/value fields for achievements
Browse files Browse the repository at this point in the history
  • Loading branch information
@Garanas
Garanas committed Apr 6, 2024
1 parent ad8f1e4 commit a132700
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions lua/sim/score.lua
View file
Expand Up @@ -14,8 +14,14 @@ local categoriesToCollect = {
air = categories.AIR,
naval = categories.NAVAL,
cdr = categories.COMMAND,
sacu = categories.SUBCOMMANDER,
engineer = categories.ENGINEER,
tech1 = categories.TECH1,
tech2 = categories.TECH2,
tech3 = categories.TECH3,
experimental = categories.EXPERIMENTAL,
structures = categories.STRUCTURE,
transportation = categories.TRANSPORTATION
}

-- Format specifications for achievements: https://github.com/FAForever/fa/issues/5813
Expand Down

2 comments on commit a132700

@lL1l1
Copy link
Contributor

@lL1l1 lL1l1 commented on a132700 Apr 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Garanas Shouldn't this work inside categoriesForAchievements? categoriesForAchievements are only logged at the end of the game, while categoriesToCollect are logged constantly during the game for use by leaderboards (for example supreme scoreboard). Also I removed the tech and engineer categories 8381682 because even though they're tracked events, they are not used for any achievements.

TRANSPORTATION and SUBCOMMANDER also work from inside categoriesForAchievements in my testing.

@lL1l1
Copy link
Contributor

@lL1l1 lL1l1 commented on a132700 Apr 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6058

Please sign in to comment.