Log re-added achievement values at end of game only #6058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lL1l1
referenced
this pull request
Apr 6, 2024
|
Great find 👍 , that's a lot better 😄 ! |
Garanas
approved these changes
Apr 6, 2024
Garanas
reviewed
Apr 6, 2024
Garanas
pushed a commit
that referenced
this pull request
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
Resolves a132700#commitcomment-140697683
Only log the re-added achievement categories at the end of the game.
Testing done on the proposed changes
Add
LOG(repr(ArmyScore))afterGameOverScorefa/lua/sim/score.lua
Lines 344 to 347 in 0944ed6
Spawn SACUs, build an air factory, and build some tech 1 and tech 2 transports from it. Press end game in the main menu. The log should show how many SACU were spawned, how many transports were built, how many engineers there are (SACUs + 1 ACU), and the number of units for each tech tier.
Checklist