Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating spelling, punctuation #2832

Merged
merged 3 commits into from
Jul 24, 2019
Merged

Updating spelling, punctuation #2832

merged 3 commits into from
Jul 24, 2019

Conversation

eforgacs
Copy link
Contributor

This branch is for bugfixes, general improvements, and new features. If your change is designed to alter balance, please make
sure your changes are rebased onto [development/balance] (https://github.com/FAForever/fa/tree/development/balance), and target that branch with your PR.

@speed2CZ
Copy link
Member

You have to fix it in this file https://github.com/FAForever/fa/blob/develop/loc/US/strings_db.lua#L7201-L7236
Else it won't show.

@eforgacs
Copy link
Contributor Author

You have to fix it in this file https://github.com/FAForever/fa/blob/develop/loc/US/strings_db.lua#L7201-L7236
Else it won't show.

Thanks, just changed that file as well.

@PhilipJFryFAF PhilipJFryFAF changed the base branch from develop to deploy/fafdevelop July 24, 2019 20:18
@PhilipJFryFAF
Copy link
Contributor

changed the branch since changes go into deploy/fafdevelop at first
https://github.com/FAForever/fa/wiki/Deployment-path-and-contribution-guidelines

@PhilipJFryFAF PhilipJFryFAF added this to the 3708 milestone Jul 24, 2019
@PhilipJFryFAF PhilipJFryFAF merged commit 19f6fa2 into FAForever:deploy/fafdevelop Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants