Refactoring connectivity windows #3658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is delayed until #3659 is merged. |
|
Will the new connection window show "jitter" i.e. min / max values of the ping? Fluctuating ping often indicates loss of packets / lack of bandwidth while a stable 400 ping could be completely fine. |
|
Yes - the idea is this:
But then with a better UI. The box plot will be more informative about how the ping evolves over time. Left is 0 ping, right is 600 ping. The tooltip will contain a description of the boxplot so that people can make their own interpretations. It will also contain the fact that any (stable) ping < 500 is fine, to help all those poor Australians 😄 . |
Garanas
force-pushed
the
improve-disconnection-dialog
branch
from
53efb0d
to
3e840e6
Compare
|
Closing due to the introduction of the new UI build pattern, which this PR doesn't use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the connectivity windows to:
(2) is done by appending the ping with a box plot: we sample the ping over X seconds and compute some statistical data over it. We visualize this with a small box plot. The tooltip will contain information about what is seen in the box plot. This should give you a better idea of how the connection between you and someone else performs.
(3) is done by adding a button that allows you to send your ping information to the game. As an example, if you suspect someone is lagging then you can click this button and the boxplot is translated to some string that represents the relevant information.