Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common Army #4131

Merged
merged 5 commits into from
Oct 4, 2022
Merged

Common Army #4131

merged 5 commits into from
Oct 4, 2022

Conversation

KionX
Copy link
Collaborator

@KionX KionX commented Aug 16, 2022

New lobby options. Modifies team management.

  • Union control for team:
    You can switch focus between allies. Works best with "Shared radar intel ranges"

  • Uses a single army for team:
    With one army per team. No need to switch focus, shared resources and units.

The number of ACUs, AIs and the locations do not change.

Uses FAForever/FA-Binary-Patches@fd7b089

@Garanas
Copy link
Member

Garanas commented Aug 16, 2022

Is this similar to the shared army modification?

@KionX
Copy link
Collaborator Author

KionX commented Aug 16, 2022

Yes. And I have already done similar things in Coop.

@Garanas
Copy link
Member

Garanas commented Aug 16, 2022

Exciting, could you tell me how it works in practice?

@KionX
Copy link
Collaborator Author

KionX commented Aug 16, 2022

Updated description.

@Garanas
Copy link
Member

Garanas commented Aug 16, 2022

I understand now, that sounds exciting 👍 , I'll adjust the english translations slightly

@Garanas Garanas added the area: sim Area that is affected by the Simulation of the Game label Aug 18, 2022
@Penguin5
Copy link
Contributor

This looks interesting. Would this basically obsolete the share condition when enabled, keeping all units alive similarly to how full share does? If so, perhaps it should be listed as a new share condition in the lobby options instead of as another type of option?

@KionX
Copy link
Collaborator Author

KionX commented Aug 19, 2022

This is not related to the share condition.

@Penguin5
Copy link
Contributor

Okay, neat. I really like this idea.

@Garanas
Copy link
Member

Garanas commented Aug 19, 2022

We'll merge it after the release is stable, for testing on FAFDevelop

KionX referenced this pull request in FAForever/FA-Binary-Patches Aug 20, 2022
@Uveso
Copy link
Contributor

Uveso commented Aug 20, 2022

@KionX

Dude, thats AWESOME !!!

@KionX
Copy link
Collaborator Author

KionX commented Aug 22, 2022

I think I've done enough.

@Garanas
Copy link
Member

Garanas commented Aug 22, 2022

I'll review it and make changes accordingly, once we're certain that the last release is stable I'll merge it in. Great job, looking forward to it!

@KionX
Copy link
Collaborator Author

KionX commented Sep 24, 2022

Up

@Garanas
Copy link
Member

Garanas commented Oct 1, 2022

Apologies for it taking so long, I've tested it, and it appears to work like a charm! I've adjusted the English description to be more descriptive, exactly telling you what you're getting yourself into as a player. I've also turned it into a team option instead of a global option, as it feels like it fits there better.

@Garanas
Copy link
Member

Garanas commented Oct 1, 2022

@KionX / @4z0t could either of you look at the Russian translation, make it match the English one? After that this PR can get merged in by either me or @Hdt80bro

lua/ui/lobby/lobbyOptions.lua Outdated Show resolved Hide resolved
loc/US/strings_db.lua Outdated Show resolved Hide resolved
@Spikey84
Copy link
Contributor

Spikey84 commented Oct 2, 2022

Ive been playing a lot of shared armies lately and have been rather unimpressed with the performance lately. Its exciting to know that a better version will be made available. Whats the ETA on this change being added to faf dev? Will this fix the common shared army issues such as units not responding to orders and difficulty selecting acus at the start of games?

@KionX
Copy link
Collaborator Author

KionX commented Oct 4, 2022

Merge this.

@Garanas Garanas merged commit 336e992 into FAForever:deploy/fafdevelop Oct 4, 2022
@Spikey84
Copy link
Contributor

Spikey84 commented Oct 8, 2022

I just tested this feature and there seems that there are issues (assuming i am using the feature as intended). When i did a 2v2 with shared control and 1 army, the game launched and only allowed us to use 1 acu(as intended) but instead of the enemy having their own armys, they were on my army as well. My understanding that it should work like shared armies (the mod) and each team 1 army that they can all control. A video of the game can be seen on https://www.twitch.tv/stellartactician 's latest vod. Replay is https://replay.faforever.com/18218863

@KionX
Copy link
Collaborator Author

KionX commented Oct 9, 2022

It should be working properly now.

@tshakah
Copy link

tshakah commented Oct 1, 2023

How can you use this? I've been searching in the forum, the code and wiki and can't see how to actually change armies. Is it available in a PvE lobby?

@Garanas
Copy link
Member

Garanas commented Oct 2, 2023

It is a lobby option 😃 , the host can enable / disable it

@tshakah
Copy link

tshakah commented Oct 2, 2023

I've tried that, and it didn't work. How do you actually control allied units?

I have been using the "multiple armies, union control" option with friends and I can't see how to control allied units.

I haven't tested the single army option with human players, but with AI teammates it spawned us as normal, and I couldn't control them.

@KionX
Copy link
Collaborator Author

KionX commented Oct 2, 2023

Checked it out. Works as it should.
Switch to the army you want to control(use the list of players). Cheats are not needed.

There should have been another engine patch that made switching unnecessary. But its acceptance is in an uncertain state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: sim Area that is affected by the Simulation of the Game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants