Introduce mission briefings to the lobby #4490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
speed2CZ
added
area: ui
|
Never seen the non-forged alliance campaign logs, quite exciting 😄 It appears the background sound can't be found: WARNING: Error resolving bank 'Op_Briefing_Vanilla' to audio engine
WARNING: Error resolving bank 'Op_Briefing_Vanilla' to audio engine
WARNING: Error resolving bank 'Op_Briefing_Vanilla' to audio engine
WARNING: Error resolving bank 'Op_Briefing_Vanilla' to audio engine |
speed2CZ
force-pushed
the
briefings
branch
2 times, most recently
from
4ad0df8
to
001e0be
Compare
|
Please use Layouter! It is impossible to read that whole UI code. |
4z0t
requested changes
Dec 24, 2022
4z0t
requested changes
Dec 24, 2022
|
It's ready now. Updated description |
Garanas
force-pushed
the
deploy/fafdevelop
branch
2 times, most recently
from
d0a77bd
to
4c8aca6
Compare
Briefing button shows up if the selected map has valid briefing data. The button takes priority over patch notes button. New UI screen with the briefing is created over the lobby.
Launch button is disabled since launching the original version of the map with FAF is very unstable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefing button shows up if the selected map has valid briefing data.
The button takes priority over patch notes button.
New UI screen with the briefing is created over the lobby.
Briefing screen can still be accessed via original Campaign selection.
Launch button is disabled there as it's unstable to launch the original missions with FAF changes.
Requires FAForever/faf-coop-maps#394
Will also require the coop patch with the missing videos and voices.