Fix slot swapping from map preview #4550
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The slight change to not upvalue
self
intoCombo
's methods by not closing each in the initializer (so that it could become part of the class) in this PR revealed a latent bug in how the map preview ACUButton is dealt with in the lobby. Namely, its roll over callback was passing itself as the instance in the slot name combo event handler, which it is not able to cope with before passing on the event to the slot's default event handler. This produces this pair of warnings, which prevents the rest of the event getting handled: