Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug and extend the context based templates feature #6015

Merged
merged 5 commits into from
Mar 21, 2024

Conversation

Garanas
Copy link
Member

@Garanas Garanas commented Mar 21, 2024

Description of the proposed changes

Related to this bug report on Discord. The bug was that a tech 1 engineer can not create the storage template when trying to cap a tech 2 extractor because the tech 2 extractor would block the template as a tech 1 engineer can't build it. We fix that by trying to build the unit it upgrades from, or by trying to build the unit it originates from.

Next to that we extend the feature by allowing it to act like a color picker - if we're hovering over a unit or a build order and we can't find matching templates then we'll try to enter command mode with a build order for the given unit and/or blueprint order. This is inspired by the featured of @4z0t mentioned on the forums.

context-based-templates-100.mp4

Testing done on the proposed changes

Spawning in structures and triggering the hotkey in various conditions.

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

@Garanas Garanas added the feature: context-based templates related to context-based templates functionality label Mar 21, 2024
@Garanas
Copy link
Member Author

Garanas commented Mar 21, 2024

With these changes you can do the following:

context-based-templates-101.mp4

@Garanas Garanas marked this pull request as ready for review March 21, 2024 21:07
@Garanas Garanas merged commit c791194 into deploy/fafdevelop Mar 21, 2024
1 check passed
@Garanas Garanas deleted the Fix/context-based-templates branch March 21, 2024 21:09
@Garanas Garanas mentioned this pull request Mar 23, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: context-based templates related to context-based templates functionality type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant