Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert hoplite firing from transports #6094

Merged

Conversation

lL1l1
Copy link
Contributor

@lL1l1 lL1l1 commented Apr 18, 2024

Reverts Hoplites firing from transports due to the animation looking bad (the head/turret looks like it is attached to the transport, but it is still allowed to rotate).

Checklist

  • Changes are documented in the changelog for the next game version

Due to animation ugliness
@lL1l1 lL1l1 added area: balance related to units balance DO NOT MERGE Don't Merge until removed labels Apr 18, 2024
@lL1l1 lL1l1 requested a review from MrRowey April 18, 2024 05:01
@MrRowey MrRowey merged commit 7993337 into FAForever:deploy/fafdevelop Apr 18, 2024
clyfordv added a commit to clyfordv/fa that referenced this pull request Apr 23, 2024
commit ceb09ce
Author: Josh <row.josh02@gmail.com>
Date:   Tue Apr 23 09:35:48 2024 +0100

    Balance : TML Hp Reduction & Adds Death Weapon (FAForever#6104)

    Co-authored-by: lL1l1 <82986251+lL1l1@users.noreply.github.com>

commit 23ebe48
Author: lL1l1 <82986251+lL1l1@users.noreply.github.com>
Date:   Mon Apr 22 12:06:13 2024 -0700

    Fix units not rebuilding on army transfer (FAForever#6106)

commit 5f7b2a9
Author: clyf <clyfordv@gmail.com>
Date:   Mon Apr 22 04:15:20 2024 -0400

    Simplify and robustify transport cargo killing and veterancy (FAForever#6091)

    Co-authored-by: lL1l1 <82986251+lL1l1@users.noreply.github.com>

commit d3ef3c0
Author: lL1l1 <82986251+lL1l1@users.noreply.github.com>
Date:   Sun Apr 21 10:02:18 2024 -0700

    Inherit all damage data in Ahwassa bomb script (FAForever#6102)

commit f925f48
Author: lL1l1 <82986251+lL1l1@users.noreply.github.com>
Date:   Sat Apr 20 22:21:57 2024 -0700

    Refactor collision beams (FAForever#6065)

commit 24abffa
Author: G C <37224614+Hdt80bro@users.noreply.github.com>
Date:   Sat Apr 20 08:45:44 2024 -0700

    Quicken inevitable voting results (FAForever#5088)

commit 2547d18
Author: (Jip) Willem Wijnia <w.b.wijnia@gmail.com>
Date:   Sat Apr 20 09:28:24 2024 +0200

    Introduce basic anti-spam protection from taunts (FAForever#6099)

commit 1635090
Author: (Jip) Willem Wijnia <w.b.wijnia@gmail.com>
Date:   Sat Apr 20 09:25:23 2024 +0200

    Revert "Remove mass from dead trees and tree groups" (FAForever#6101)

commit ca94bd8
Author: lL1l1 <82986251+lL1l1@users.noreply.github.com>
Date:   Fri Apr 19 15:09:17 2024 -0700

    Revert "Remove mass from dead trees and tree groups" (FAForever#6100)

commit 524fc7f
Author: clyf <clyfordv@gmail.com>
Date:   Fri Apr 19 10:42:27 2024 -0400

    Fix being able to detach the external factory of the primary unit (FAForever#6093)

commit 7993337
Author: lL1l1 <82986251+lL1l1@users.noreply.github.com>
Date:   Thu Apr 18 00:53:13 2024 -0700

    Revert hoplite firing from transports (FAForever#6094)
@lL1l1 lL1l1 removed the DO NOT MERGE Don't Merge until removed label May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: balance related to units balance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants