Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entity + dummy Unit in between ExFac and ExFacUnit #6093

Merged

Conversation

clyfordv
Copy link
Contributor

  1. Re-adds the entity attached to the external factory base unit. This prevents "deploy" on the fatboy from detaching the external factory.
  2. Adds another (newly defined) dummy unit in between the entity and the external factory. The dummy unit has the "CARRIER" category which prevents the external factory from being highlighted or selected in the worldview with the cursor, but still allows it to be selected with the exFac button.

@lL1l1 lL1l1 added area: sim Area that is affected by the Simulation of the Game feature: mobile factories related to mobile factory functionality type: bug labels Apr 18, 2024
@Garanas Garanas linked an issue Apr 18, 2024 that may be closed by this pull request
@apollodeathstar
Copy link
Contributor

@clyfordv mild request : can make it so the assist command from the external factory when selected to assist the fatboy unit itself causes units produced by the external factory to surround/guard the fatboy like they do when a unit is selected and told to assist the fatboy body normally? right now the fatboy external factory can only have a set rally point that stays statically behind the fatboy and units get produced and left behind. This way you can have units produced by the factory stay with the fatboy as it advances/fights.

Currently when you use the assist command from the external factory to the main body it simply cancels all its production queue.

@clyfordv
Copy link
Contributor Author

Currently the exFacs, like normal factories, can only assist other factories and can't have assist orders on units (you see it yourself, you can give assist commands to units but the engine eats it after a beat). The canceling the production queue is likely because the exFac thinks on some level that it's being given an assist order to another factory (even though the base unit has no production capability), which has the same result.

But, but, if there was another unit sitting around somewhere, related to the exFac, like a dummy unit, we could task that unit with tracking the assist target (or rally point entirely, which would probably be cleaner).

@Garanas
Copy link
Member

Garanas commented Apr 19, 2024

Let's first finalize these changes however to fix the bug 😃 !

@clyfordv
Copy link
Contributor Author

We're good to go. I was experimenting with trimming down the dummy units bp to the absolute minimum viable but that can happen later.

@clyfordv clyfordv marked this pull request as ready for review April 19, 2024 13:37
@Garanas Garanas self-requested a review April 19, 2024 13:58
@Garanas
Copy link
Member

Garanas commented Apr 19, 2024

It is still possible to detach the unit that you're building:

image

@Garanas
Copy link
Member

Garanas commented Apr 19, 2024

but I'll take this pull request, it fixes the problem that matters the most

@Garanas Garanas merged commit 524fc7f into FAForever:deploy/fafdevelop Apr 19, 2024
@clyfordv
Copy link
Contributor Author

Is it known if detaching the unit was possible with the original original version, with just the entity? And do you reckon adding the carrier category to the exFac would mess anything else up? (because I think that would solve the problem)

@Garanas
Copy link
Member

Garanas commented Apr 19, 2024

No idea - we'd need to try and see what happens

clyfordv added a commit to clyfordv/fa that referenced this pull request Apr 23, 2024
commit ceb09ce
Author: Josh <row.josh02@gmail.com>
Date:   Tue Apr 23 09:35:48 2024 +0100

    Balance : TML Hp Reduction & Adds Death Weapon (FAForever#6104)

    Co-authored-by: lL1l1 <82986251+lL1l1@users.noreply.github.com>

commit 23ebe48
Author: lL1l1 <82986251+lL1l1@users.noreply.github.com>
Date:   Mon Apr 22 12:06:13 2024 -0700

    Fix units not rebuilding on army transfer (FAForever#6106)

commit 5f7b2a9
Author: clyf <clyfordv@gmail.com>
Date:   Mon Apr 22 04:15:20 2024 -0400

    Simplify and robustify transport cargo killing and veterancy (FAForever#6091)

    Co-authored-by: lL1l1 <82986251+lL1l1@users.noreply.github.com>

commit d3ef3c0
Author: lL1l1 <82986251+lL1l1@users.noreply.github.com>
Date:   Sun Apr 21 10:02:18 2024 -0700

    Inherit all damage data in Ahwassa bomb script (FAForever#6102)

commit f925f48
Author: lL1l1 <82986251+lL1l1@users.noreply.github.com>
Date:   Sat Apr 20 22:21:57 2024 -0700

    Refactor collision beams (FAForever#6065)

commit 24abffa
Author: G C <37224614+Hdt80bro@users.noreply.github.com>
Date:   Sat Apr 20 08:45:44 2024 -0700

    Quicken inevitable voting results (FAForever#5088)

commit 2547d18
Author: (Jip) Willem Wijnia <w.b.wijnia@gmail.com>
Date:   Sat Apr 20 09:28:24 2024 +0200

    Introduce basic anti-spam protection from taunts (FAForever#6099)

commit 1635090
Author: (Jip) Willem Wijnia <w.b.wijnia@gmail.com>
Date:   Sat Apr 20 09:25:23 2024 +0200

    Revert "Remove mass from dead trees and tree groups" (FAForever#6101)

commit ca94bd8
Author: lL1l1 <82986251+lL1l1@users.noreply.github.com>
Date:   Fri Apr 19 15:09:17 2024 -0700

    Revert "Remove mass from dead trees and tree groups" (FAForever#6100)

commit 524fc7f
Author: clyf <clyfordv@gmail.com>
Date:   Fri Apr 19 10:42:27 2024 -0400

    Fix being able to detach the external factory of the primary unit (FAForever#6093)

commit 7993337
Author: lL1l1 <82986251+lL1l1@users.noreply.github.com>
Date:   Thu Apr 18 00:53:13 2024 -0700

    Revert hoplite firing from transports (FAForever#6094)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: sim Area that is affected by the Simulation of the Game feature: mobile factories related to mobile factory functionality type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External factory can be deattached by deploying
4 participants