Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Aeon M2 objective SCCA_Coop_A02_script.lua #410

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

maudlin27
Copy link
Contributor

Fixes a bug that can break Aeon mission 2 if the stealthed base is detected too soon (causing the stealthed base objective to trigger first, which breaks the mission if mission 2 (of mission 2) hasn't triggered yet.

For further details see:
https://discord.com/channels/944679492293636116/944697747376853003/1132011694131007569

Fixes a bug that can break Aeon mission 2 if the stealthed base is detected too soon
@@ -676,6 +676,10 @@ function M2AssignSecretBaseObjective()
end
end
)
--Sometimes this objective can trigger before the objective group is created since this is linked to when one of the naval base units is detected
while not(ScenarioInfo.M2ObjectiveGroup.AddObjective) do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be just ScenarioInfo.M2ObjectiveGroup, without AddObjective

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Just check if there is a valid objective group (i.e. remove the check of whether that group has an AddObjective function)
@speed2CZ speed2CZ merged commit 96fbb66 into FAForever:master Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants