Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link games with their originating matchmaker queue #599

Closed
Askaholic opened this issue Jun 3, 2020 · 0 comments · Fixed by #654
Closed

Link games with their originating matchmaker queue #599

Askaholic opened this issue Jun 3, 2020 · 0 comments · Fixed by #654
Assignees
@cleborys
Projects
Team Matchmaker
Milestone
Matchmaker

Comments

@Askaholic
Copy link
Collaborator

For the anti map repetition code to work we need a way of telling when a game was started from a particular queue. Right now there is only one queue games started from it have the gametype ladder1v1. But for future tmm queues this will not be the case.

Proposed solutions

  1. Add a nullable matchmaker_queue_id column to game_stats table.
    The problem is that game_stats is a big table, and the majority of games will have a null value here. This is a lot of wasted space.
  2. Introduce some sort of m:n table for linking queues to games.
    Takes less space, but requires an extra join when querying. Can also link multiple queues to the same game, but I'm not sure what the use case for that would be.
@Askaholic Askaholic added this to the Matchmaker milestone Jun 3, 2020
@Askaholic Askaholic added this to To do in Team Matchmaker Jun 3, 2020
@cleborys cleborys self-assigned this Sep 3, 2020
@cleborys cleborys moved this from To do to Review in Team Matchmaker Sep 3, 2020
@cleborys cleborys mentioned this issue Sep 3, 2020
Merged
@Askaholic Askaholic moved this from Review to In progress in Team Matchmaker Sep 3, 2020
@cleborys cleborys mentioned this issue Sep 7, 2020
Merged
@Askaholic Askaholic moved this from In progress to Review in Team Matchmaker Sep 24, 2020
Team Matchmaker automation moved this from Review to Done Oct 3, 2020
Askaholic pushed a commit that referenced this issue Oct 3, 2020
@cleborys
Feature/#599 Link games with their originating matchmaker queue (#654)
537c86f 
* Add matchmaker_queue_game table

* Write originating mm_queue on game start

Not using it for recent match lookup yet

* Use matchmaker_queue in LadderService.get_game_history

* Temporarily add migration to travis

* Fix flake8 checks

* Add id column to matchmaker_queue_game table

* Store and use matchmaker queue id

* Remove manual migration

* Dont shadow id in function parameter

* Add tmm2v2 ladder history tests

* Update DB_VERSION for travis
@andrewmiko andrewmiko mentioned this issue Oct 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cleborys cleborys

Labels
None yet
Projects
Team Matchmaker
  
Done
Milestone
Matchmaker
Development

Successfully merging a pull request may close this issue.

Feature/#599 Link games with their originating matchmaker queue cleborys/server
2 participants
@cleborys @Askaholic