Enhancement/#676 remove python version check

[andrewmiko]

Removed client_version_info from project.

1. isort show sorting error in file which I didn't edited
2. flake8 throws tons of errors on local env
3. Didn't update Pipfile only because it's trying to upgrade all packages (it's ignoring --keep-outdated flag)

I can update PR later with all necessary changes.

Closes #676

[Askaholic]

@Brutus5000 Thoughts on keeping the user agent check?

[Askaholic]

Oh and I can take care of the Pipfile and Pipfile.lock in a separate PR. That's no problem

[Askaholic]

Another thing I just noticed was that there are references to the version_lobby table in our test-data.sql file. We should remove those too so our tests don't break when the table is dropped.

And you'll need to rebase.

[andrewmiko]

@Askaholic

OK, I'm first time doing rebase and I need little help here.

Current branch is ahead of develop to 10 commits:

• 7aa21c6 Removed semver package deprecation warning from pytest
• 6c26c31 Removed _check_version method and semver package
• 5105dbd Removed client_version_info from PlayerService
• 6f9742e Removed client_version_info from test_update_data unittest
• e21242b Removed test_server_deprecated_client test
• b088c48 Phantom games report results in a different format #663 - Phantom games report format (#663 - Phantom games report format #674)
• a321937 Restored and renamed _check_version to _check_user_agent
• fc9c508 Restored test_server_deprecated_client test
• 537c86f Feature/Link games with their originating matchmaker queue #599 Link games with their originating matchmaker queue (Feature/#599 Link games with their originating matchmaker queue #654)
• 446a9f4 Removed version_lobby from test-data.sql

Should I go back to 10 commits and squash them? git rebase -i HEAD~10
Then push --force

Right?

[Askaholic]

Sorry for taking so long to respond, somehow I overlooked this.

I usually do this:

$ git checkout develop
$ git pull upstream develop
$ git checkout my-branch
$ git rebase develop
$ git push --force

Where upstream is the remote that points to this repository (the FAForever one, not my fork). I'm not entirely sure what the interaction with merge commits is here, because I never make any, but I would expect them to just disappear during the rebase.

You shouldn't need to squash anything, and after the rebase you should be left with just the commits that you made, except that they will have been moved to be the most recent commits in the commit history.

[andrewmiko]

@Askaholic Thanks a lot. Today I will finish it then. 👍

[Askaholic]

Looks good!